🎨 Update default value for blockHeaderTimeout to 10 seconds

web3 · Sep 17, 2021 · fe1c8a4 · fe1c8a4
1 parent 1a350a4
commit fe1c8a4
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/docs/web3-eth-contract.rst b/docs/web3-eth-contract.rst
@@ -334,7 +334,7 @@ The ``blockHeaderTimeout`` is used over socket-based connections. This option de
 Returns
 -------
 
-``number``: The current value of blockHeaderTimeout (default: 5 seconds)
+``number``: The current value of blockHeaderTimeout (default: 10 seconds)
 
 ------------------------------------------------------------------------------
 

diff --git a/docs/web3-eth.rst b/docs/web3-eth.rst
@@ -392,7 +392,7 @@ The ``blockHeaderTimeout`` is used over socket-based connections. This option de
 Returns
 -------
 
-``number``: The current value of blockHeaderTimeout (default: 5 seconds)
+``number``: The current value of blockHeaderTimeout (default: 10 seconds)
 
 -------
 Example

diff --git a/packages/web3-core-method/src/index.js b/packages/web3-core-method/src/index.js
@@ -56,7 +56,7 @@ var Method = function Method(options) {
  this.transactionBlockTimeout = options.transactionBlockTimeout || 50;
  this.transactionConfirmationBlocks = options.transactionConfirmationBlocks || 24;
  this.transactionPollingTimeout = options.transactionPollingTimeout || 750;
- this.blockHeaderTimeout = options.blockHeaderTimeout || 5; // 5 seconds
+ this.blockHeaderTimeout = options.blockHeaderTimeout || 10; // 10 seconds
  this.defaultCommon = options.defaultCommon;
  this.defaultChain = options.defaultChain;
  this.defaultHardfork = options.defaultHardfork;

diff --git a/packages/web3-eth/src/index.js b/packages/web3-eth/src/index.js
@@ -100,7 +100,7 @@ var Eth = function Eth() {
  var transactionBlockTimeout = 50;
  var transactionConfirmationBlocks = 24;
  var transactionPollingTimeout = 750;
- var blockHeaderTimeout = 5;
+ var blockHeaderTimeout = 10; // 10 seconds
  var maxListenersWarningThreshold = 100;
  var defaultChain, defaultHardfork, defaultCommon;
 

diff --git a/test/eth.blockHeaderTimeout.js b/test/eth.blockHeaderTimeout.js
@@ -9,9 +9,9 @@ var setValue = 123;
 describe('web3.eth', function () {
  describe('blockHeaderTimeout', function () {
  it('should check if blockHeaderTimeout is set to proper value', function () {
- assert.equal(eth.blockHeaderTimeout, 5);
- assert.equal(eth.Contract.blockHeaderTimeout, 5);
- assert.equal(eth.getCode.method.blockHeaderTimeout, 5);
+ assert.equal(eth.blockHeaderTimeout, 10);
+ assert.equal(eth.Contract.blockHeaderTimeout, 10);
+ assert.equal(eth.getCode.method.blockHeaderTimeout, 10);
  });
  it('should set blockHeaderTimeout for all sub packages is set to proper value, if Eth package is changed', function () {
  eth.blockHeaderTimeout = setValue;