Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal.signTypedData #1073

Closed
wants to merge 1 commit into from
Closed

Add personal.signTypedData #1073

wants to merge 1 commit into from

Conversation

ukstv
Copy link

@ukstv ukstv commented Sep 23, 2017

The method signs the data along with the schema, so that a user is well informed on what she signs.
As proposed in ethereum/EIPs#712

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 90.562% when pulling 7d76e1d on ukstv:develop into 917d152 on ethereum:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 90.562% when pulling 7d76e1d on ukstv:develop into 917d152 on ethereum:develop.

@frozeman
Copy link
Contributor

As this is not accepted standard yet, and not in geth or parity i can't merge that, also it should be on the eth_ namespace, as it doesn't receive a password as last argument.

@frozeman frozeman added Discussion Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Sep 25, 2017
@frozeman
Copy link
Contributor

Im happy adding that, if there is a broad consensus.

@elenadimitrova
Copy link

Isn't there also a requirement for eth_signTypedData in addition to personal_signTypedData according to ethereum/EIPs#712

@ukstv
Copy link
Author

ukstv commented May 15, 2018

@elenadimitrova It is indeed. It doesn’t matter though as eip712 is not widely accepted. Neither geth nor parity support it.

@Amxx
Copy link

Amxx commented Sep 27, 2018

+1

@nivida
Copy link
Contributor

nivida commented Apr 16, 2019

Closed because the latest maintenance release was 0.20.7.

@nivida nivida closed this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Enhancement Includes improvements or optimizations In Progress Currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants