Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0 #4187

Merged
merged 8 commits into from
Jul 28, 2021
Merged

v1.5.0 #4187

merged 8 commits into from
Jul 28, 2021

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Jul 21, 2021

Added

Changed


An example of signing an EIP-1559 transaction with web3-eth-accounts

import Web3 from 'web3';

const web3 = new Web3(Web3.givenProvider || 'http://localhost:8545');

const txObject = {
    to: '0x...',
    value: web3.utils.toHex(web3.utils.toWei('0.1', 'ether')),
    gas: web3.utils.toHex(21000),
    maxFeePerGas: web3.utils.toHex(web3.utils.toWei('1.5', 'gwei')),
    maxPriorityFeePerGas: web3.utils.toHex(web3.utils.toWei('.5', 'gwei'))
 };

 web3.eth.accounts.signTransaction(txObject, privateKey, (err, signed) => {...});

@render
Copy link

render bot commented Jul 21, 2021

@coveralls
Copy link

coveralls commented Jul 21, 2021

Pull Request Test Coverage Report for Build 1061416194

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.811%

Totals Coverage Status
Change from base Build 1061410368: 0.0%
Covered Lines: 3305
Relevant Lines: 4287

💛 - Coveralls

@corymsmith
Copy link
Contributor

@spacesailor24 Shouldn't we also add support for the eth_feeHistory call?

@spacesailor24
Copy link
Contributor Author

@spacesailor24 Shouldn't we also add support for the eth_feeHistory call?

Yes, you're correct. This slipped through, I'll work on getting this added today

Thank you!

@spacesailor24 spacesailor24 changed the title v1.5.0-rc.0 v1.5.0-rc.1 Jul 24, 2021
@spacesailor24
Copy link
Contributor Author

@spacesailor24 Shouldn't we also add support for the eth_feeHistory call?

@corymsmith v1.5.0-rc.1 has been released, and contains getFeeHistory method within the web3-eth package

@luu-alex
Copy link
Contributor

luu-alex commented Jul 28, 2021

Replicating the steps mentioned in previous releases

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts ✔️
synthetix ~1000 units x

Running synthetix with rc 1.5.0 gives us 6 errors.

https:/Synthetixio/synthetix/tree/v2.45.0
Synthetix version 2.45.0 there already exists 5 failing testcases which can be found here. https://app.circleci.com/pipelines/github/Synthetixio/synthetix/7056/workflows/dbe8bb5b-1634-49f9-b188-6361d3e1814f/jobs/64364

@spacesailor24
Copy link
Contributor Author

Failing Synthetix tests appear to be unrelated to web3.js, moving forward with release

@spacesailor24 spacesailor24 marked this pull request as ready for review July 28, 2021 21:37
luu-alex
luu-alex previously approved these changes Jul 28, 2021
GregTheGreek
GregTheGreek previously approved these changes Jul 28, 2021
@GregTheGreek GregTheGreek self-requested a review July 28, 2021 21:42
@GregTheGreek GregTheGreek dismissed their stale review July 28, 2021 21:42

need to remove rc suffix

@spacesailor24 spacesailor24 changed the title v1.5.0-rc.1 v1.5.0 Jul 28, 2021
Copy link
Contributor

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants