Revert #4437 (@types/bn.js) #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested changes
Oct 20, 2021
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "version": "1.6.0", | |||
| "version": "1.6.1-rc.0", | |||
There was a problem hiding this comment.
Does this version not already published? 1.6.1-rc.0, Should not we consider this as 1.6.1-rc.1?
There was a problem hiding this comment.
No, RC version will get bumped in the release/1.6.1 branch after 1.x branch is updated with these changes. Flow is:
New changes -> 1.x -> release/1.6.1 -> Bump RC version -> release next RC
|
same question as Nazar, also github actions still 'Waiting for status to be reported' after long time. |
nazarhussain
approved these changes
Oct 20, 2021
|
Your Render PR Server URL is https://web3-js-pr-4481.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5o64g46fj303gfp5qb0. |
jdevcs
approved these changes
Oct 20, 2021
Pull Request Test Coverage Report for Build 1364873516
💛 - Coveralls |
This was referenced Feb 11, 2022
This was referenced Feb 11, 2022
This was referenced Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the PR #4481 and we think it was causing dependency issues - will be included in a later release