Stop waiting after transactionBlockTimeout
#5294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this is a draft code that needs to be finished after, or along with: #5293)
|
Your Render PR Server URL is https://web3js-docs-pr-5294.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbhd26uhb05sparsh130. |
…ttps:/ChainSafe/web3.js into fix/5293/interrupt-waiting-for-node-after-timeout
+ tiny code cleaning
+ and increase `transactionPollingTimeout` to 2000
…ting-for-node-after-timeout
+ revert CHANGELOG.md white spaces change
…ttps:/ChainSafe/web3.js into fix/5293/interrupt-waiting-for-node-after-timeout
avkos
approved these changes
Sep 7, 2022
luu-alex
reviewed
Sep 9, 2022
|
LGTM, just a small comment. overall great work |
luu-alex
approved these changes
Sep 9, 2022
jdevcs
reviewed
Sep 9, 2022
Co-authored-by: Junaid <[email protected]>
…' of https:/ChainSafe/web3.js into feature/5113/stop-waiting-after-transactionBlockTimeout
nikoulai
approved these changes
Sep 11, 2022
jdevcs
approved these changes
Sep 12, 2022
…ing-after-transactionBlockTimeout
+ and switch the location and change the names of 2 error classes
…ing-after-transactionBlockTimeout
…ing-after-transactionBlockTimeout
2 tasks
+ code cleaning and adding comments
Muhammad-Altabba
deleted the
feature/5113/stop-waiting-after-transactionBlockTimeout
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5113
Also, refactored the code at
waitForTransactionReceiptand a few other enhancements.And added 3 reusable utility functions at web3-utils:
pollTillDefined,rejectIfTimeoutandrejectIfConditionAtInterval. Which are useful when dealing with promises that involve polling, rejecting after a timeout, or rejecting if a condition was met when calling repeatably at every time intervals.Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.