Fix multi dimensional array validation issue #6435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently for a multi-dimensional array (bounded or unbounded) that follows a sibling field (is not the first field defined in its level), extrwcted JSON scheme is missing some field.
Sample ABI
Expected JSON Scheme
Actual JSON Scheme
This is due to mishandling of multi-dimensional arrays when ABI is converted to JSON scheme leading to loss of parts of the scheme (in this case 'x1' input parameter from the ABI is discarded).
Fixed that and added a unit test payload to verify.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.