Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infura tests and secrets #7163

Merged
merged 24 commits into from
Aug 2, 2024
Merged

fix infura tests and secrets #7163

merged 24 commits into from
Aug 2, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jul 18, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #4058

  • Replaces secret end points to only use mainnet and Sepolia
  • Fixes e2e tests to run async so that we arent rate limited by infura (will still need to re-run sometimes but tests now pass more consistently)
  • Changed tests that use a blockhash or block number to use one of the latest blocks so we aren't using archive nodes from infura.
  • Ran formatter

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jul 19, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 636.12 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 616.83 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 66316d2 Previous: cbbbd84 Ratio
processingTx 8867 ops/sec (±4.98%) 9422 ops/sec (±3.54%) 1.06
processingContractDeploy 39811 ops/sec (±6.52%) 40005 ops/sec (±6.29%) 1.00
processingContractMethodSend 15484 ops/sec (±7.84%) 15941 ops/sec (±7.57%) 1.03
processingContractMethodCall 27730 ops/sec (±7.64%) 27197 ops/sec (±8.39%) 0.98
abiEncode 41599 ops/sec (±7.04%) 45246 ops/sec (±6.54%) 1.09
abiDecode 28666 ops/sec (±8.42%) 30727 ops/sec (±7.98%) 1.07
sign 1497 ops/sec (±3.06%) 1542 ops/sec (±2.93%) 1.03
verify 361 ops/sec (±1.06%) 374 ops/sec (±0.56%) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (cbbbd84) to head (66316d2).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7163   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         215      215           
  Lines        8396     8396           
  Branches     2315     2315           
=======================================
  Hits         7931     7931           
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex luu-alex changed the title fix secrets fix infura tests and secrets Jul 29, 2024
@luu-alex luu-alex marked this pull request as ready for review July 29, 2024 18:42
@luu-alex
Copy link
Contributor Author

Commit 7f349fb with e2e and blackbox test cases passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants