reqwest 0.10.1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
commented
Feb 10, 2020
webern
force-pushed
the
webern/reqwest-10
branch
2 times, most recently
from
9dfd477
to
cebc00f
Compare
webern
force-pushed
the
webern/reqwest-10
branch
from
cebc00f
to
7c03d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In another project we experienced failures using http 1.1 over TLS. This was tracked to
hyperwhere we believe we had a slightly different manifestation of this issue hyper 1439 (in our case a closed connection was being used leading to a "Failed to fetch" error).The
hyperwas fixed inv0.13which is obtained by bumpingreqwestfrom0.9to0.10.In
reqwest0.10 the non-async api is relegated to thereqwest::blockingmodule. This is breaking for customers oftoughsincepub type HttpTransport = reqwest::Client;becomespub type HttpTransport = reqwest::blocking::Client;. However the code changes required to accommodate this are as simple as adding::blocking::to the path wherever the compiler complains.This change was tested in an update program that uses
toughand was found to fix the issue.