Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sync check #322

Merged
merged 1 commit into from
Mar 16, 2020
Merged

chore: remove sync check #322

merged 1 commit into from
Mar 16, 2020

Conversation

ryanclark
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Remove the sync check and pass through the loaderContext.callback from this.async

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@alexander-akait alexander-akait merged commit fed50ba into master Mar 16, 2020
@alexander-akait alexander-akait deleted the remove-sync-check branch March 16, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants