Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass worker hangs on js compilation errors under certain circumstance #523

Closed
JLHwung opened this issue Dec 25, 2017 · 3 comments
Closed

Comments

@JLHwung
Copy link

JLHwung commented Dec 25, 2017

I come across webpack hanging on company building machine. After hours and hours I manage to craft a tiny example ( link ) and reproduce it on my mac as well as travis ( link ).

Travis errored due to timeout and it is expected to fail immediately.

When webpack throws js compilation errors, chances are node-sass just setup a worker to compile sass and this worker does not get closed while the webpack exits. Thue webpack is hang.

Related issues may be sass/node-sass#857 but I am not sure if it is same issue.

This issue may involve several teams and I hope we can work together to fix. Before we fix the issue

As noted by @crvv the following is invalid and does not work at all.
I also find a workaround for this specific hanging situation:-

UV_THREADPOOL_SIZE=1 webpack --config ./config.js

It will disable the asyncQueue of sass-loader. Use at your own risk.

@alexander-akait
Copy link
Member

@JLHwung can you provide minimum reproducible test repo?

@JLHwung
Copy link
Author

JLHwung commented Dec 26, 2017

After hours and hours I manage to craft a tiny example ( link ) and reproduce it on my mac as well as travis ( link ).

@evilebottnawi The minimal example is https:/JLHwung/webpack-sass-worker-hang-example.

It shall be fixed by webpack/webpack#6193, yet any further explanation is also definitely welcome.

@JLHwung
Copy link
Author

JLHwung commented Dec 30, 2017

Closed since webpack/webpack#6193 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants