Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct stats generation in webpack 5 #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergiocarracedo
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The stats generation via buildModuleMap uses module.id which doesn't exist in webpack 5 returning just the last module (as the key of the map is always undefined)

Breaking Changes

NONE: Still prioritizing module.id, if it is not defined fallback the value to index or identifier

Additional Info

Copy link

linux-foundation-easycla bot commented Aug 8, 2024

CLA Signed

  • ✅login: sergiocarracedo / (8934430)

The committers listed above are authorized under a signed CLA.

@alexander-akait
Copy link
Member

Can you accept CLA?

@sergiocarracedo sergiocarracedo force-pushed the chore/correct-stats-generation-webpack-5 branch from 2eb9ed5 to 8934430 Compare August 8, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants