change-codecs: move codec selection to the receiver #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
Nov 20, 2023
| transceiver.setCodecPreferences(codecs); | ||
| console.log('Preferred video codec', selectedCodec); | ||
| } | ||
| } | ||
| codecPreferences.disabled = true; |
There was a problem hiding this comment.
Is this still reasonable? (I assume it's turned back on after negotiation finishes)
There was a problem hiding this comment.
It is going to be turned until the end of the call until we support @Orphis' cool stuff
While using setCodecPreferences on the sending side works because the answerer will match the sender's order, using it on the receiving end is more semantically correct. See this comment w3c/webrtc-encoded-transform#186 (comment)
fippo
force-pushed
the
setcodecpreferences-receiver
branch
from
ff61251
to
cb5943b
Compare
alvestrand
approved these changes
Nov 20, 2023
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Nov 25, 2023
follow-up to webrtc#1640 which got copy-pasted quite a bit.
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Nov 25, 2023
follow-up to webrtc#1640 which got copy-pasted quite a bit.
fippo
added a commit
to fippo/simulcast-playground
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using setCodecPreferences on the sending side works because the answerer will match the sender's order, using it on the receiving end is more semantically correct.
See this comment
w3c/webrtc-encoded-transform#186 (comment)