Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Commit

Permalink
refactor(useForm): prevent un-necessary default values checking
Browse files Browse the repository at this point in the history
  • Loading branch information
wellyshen committed Nov 27, 2020
1 parent 85c3def commit e7adb99
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/quiet-olives-bathe.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-cool-form": patch
---

refactor(useForm): prevent un-necessary default values checking
13 changes: 9 additions & 4 deletions src/useForm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export default <V extends FormValues = FormValues>({
);

const setAllNodesOrStateValue = useCallback(
(values: V, checkDefaultValue = false) =>
(values: V, checkDefaultValues = false) =>
Object.values(fieldsRef.current).forEach(({ field, options }) => {
const { name } = field;

Expand All @@ -252,7 +252,7 @@ export default <V extends FormValues = FormValues>({
const value = get(values, name);

if (!isUndefined(value)) setNodeValue(name, value);
if (checkDefaultValue)
if (checkDefaultValues)
setDefaultValue(name, getNodeValue(field, options));
}),
[getNodeValue, setNodeValue, setDefaultValue]
Expand Down Expand Up @@ -804,18 +804,23 @@ export default <V extends FormValues = FormValues>({
delete controllersRef.current[name];
});

let checkDefaultValues = false;

Object.keys(fields).forEach((name) => {
if (!fieldsRef.current[name] && initialStateRef.current.values[name])
if (!fieldsRef.current[name] && initialStateRef.current.values[name]) {
values = set(
values,
name,
initialStateRef.current.values[name],
true
);

checkDefaultValues = true;
}
});

fieldsRef.current = fields;
setAllNodesOrStateValue(values, true);
setAllNodesOrStateValue(values, checkDefaultValues);
});
observer.observe(form, { childList: true, subtree: true });

Expand Down

0 comments on commit e7adb99

Please sign in to comment.