Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Refactor(types): enhance the readability of type #256

Merged
merged 1 commit into from
Dec 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-forks-doubt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-cool-form": patch
---

refactor(types): enhance the readability of type
26 changes: 13 additions & 13 deletions src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ export type Fields = Record<
}
>;

export type FieldParsers = Record<
export type FieldArgs = Record<
string,
{
valueAsNumber?: boolean;
valueAsDate?: boolean;
parse?: Parse;
parse?: Parser;
}
>;

Expand All @@ -80,19 +80,19 @@ interface Options<V> {
submit: Submit<V>;
}

interface OnReset<V> {
interface ResetHandler<V> {
(values: V, options: Options<V>, event?: Event | SyntheticEvent<any>): void;
}

interface OnSubmit<V> {
interface SubmitHandler<V> {
(
values: V,
options: Options<V>,
event?: Event | SyntheticEvent<any>
): void | Promise<void>;
}

interface OnError<V> {
interface ErrorHandler<V> {
(
errors: Errors<V>,
options: Options<V>,
Expand Down Expand Up @@ -120,7 +120,7 @@ export interface FieldRef<V> {
validate?: FieldValidator<V>;
valueAsNumber?: boolean;
valueAsDate?: boolean;
parse?: Parse;
parse?: Parser;
}
): (field: FieldElement | null) => void;
}
Expand Down Expand Up @@ -193,11 +193,11 @@ export interface Submit<V> {
(event?: SyntheticEvent<any>): Promise<{ values?: V; errors?: Errors<V> }>;
}

interface Parse {
interface Parser {
(value: any): any;
}

type format = Parse;
type Formatter = Parser;

export interface Controller<V, E = any> {
(
Expand All @@ -206,8 +206,8 @@ export interface Controller<V, E = any> {
validate?: FieldValidator<V>;
value?: any;
defaultValue?: any;
parse?: Parse;
format?: format;
parse?: Parser;
format?: Formatter;
onChange?: (event: E, value: any) => void;
onBlur?: (event: FocusEvent<any>) => void;
}
Expand All @@ -226,9 +226,9 @@ export interface Config<V> {
validateOnBlur?: boolean;
removeUnmountedField?: boolean;
ignoreFields?: string[];
onReset?: OnReset<V>;
onSubmit?: OnSubmit<V>;
onError?: OnError<V>;
onReset?: ResetHandler<V>;
onSubmit?: SubmitHandler<V>;
onError?: ErrorHandler<V>;
debug?: Debug<V>;
}

Expand Down
32 changes: 16 additions & 16 deletions src/types/react-cool-form.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,19 @@ declare module "react-cool-form" {
submit: Submit<V>;
}

export interface OnReset<V = FormValues> {
export interface ResetHandler<V = FormValues> {
(values: V, options: Options<V>, event?: Event | SyntheticEvent<any>): void;
}

export interface OnSubmit<V = FormValues> {
export interface SubmitHandler<V = FormValues> {
(
values: V,
options: Options<V>,
event?: Event | SyntheticEvent<any>
): void | Promise<void>;
}

export interface OnError<V = FormValues> {
export interface ErrorHandler<V = FormValues> {
(
errors: Errors<V>,
options: Options<V>,
Expand Down Expand Up @@ -74,7 +74,7 @@ declare module "react-cool-form" {
validate?: FieldValidator<V>;
valueAsNumber?: boolean;
valueAsDate?: boolean;
parse?: Parse;
parse?: Parser;
}
): (
field: HTMLInputElement | HTMLTextAreaElement | HTMLSelectElement | null
Expand Down Expand Up @@ -161,17 +161,17 @@ declare module "react-cool-form" {
(event?: SyntheticEvent<any>): Promise<{ values?: V; errors?: Errors<V> }>;
}

export interface Parse<V = any, R = any> {
export interface Parser<V = any, R = any> {
(value: V): R;
}

export type Format<V = any, R = any> = Parse<V, R>;
export type Formatter<V = any, R = any> = Parser<V, R>;

export interface OnChange<E = any> {
export interface ChangeHandler<E = any> {
(event: E, value: any): void;
}

export interface OnBlur {
export interface BlurHandler {
(event: FocusEvent<any>): void;
}

Expand All @@ -182,16 +182,16 @@ declare module "react-cool-form" {
validate?: FieldValidator<V>;
value?: any;
defaultValue?: any;
parse?: Parse;
format?: Format;
onChange?: OnChange<E>;
onBlur?: OnBlur;
parse?: Parser;
format?: Formatter;
onChange?: ChangeHandler<E>;
onBlur?: BlurHandler;
}
): {
name: string;
value: any;
onChange: (event: E) => void;
onBlur: OnBlur;
onBlur: BlurHandler;
} | void;
}

Expand All @@ -202,9 +202,9 @@ declare module "react-cool-form" {
validateOnBlur?: boolean;
removeUnmountedField?: boolean;
ignoreFields?: string[];
onReset?: OnReset<V>;
onSubmit?: OnSubmit<V>;
onError?: OnError<V>;
onReset?: ResetHandler<V>;
onSubmit?: SubmitHandler<V>;
onError?: ErrorHandler<V>;
debug?: Debug<V>;
}

Expand Down
14 changes: 7 additions & 7 deletions src/useForm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import {
Config,
Controller,
Errors,
FieldArgs,
FieldElement,
FieldParsers,
FieldRef,
Fields,
FieldValidator,
Expand Down Expand Up @@ -66,7 +66,7 @@ export default <V extends FormValues = FormValues>({
const isInitRef = useRef(true);
const formRef = useRef<HTMLFormElement>(null);
const fieldsRef = useRef<Fields>({});
const fieldParsersRef = useRef<FieldParsers>({});
const fieldArgsRef = useRef<FieldArgs>({});
const controllersRef = useRef<Map>({});
const ignoreFieldsRef = useRef<Map>(arrayToMap(ignoreFields));
const changedFieldRef = useRef<string>();
Expand Down Expand Up @@ -156,7 +156,7 @@ export default <V extends FormValues = FormValues>({
const { validate, ...parsers } = validateOrOptions;

if (validate) fieldValidatorsRef.current[field.name] = validate;
fieldParsersRef.current[field.name] = parsers;
fieldArgsRef.current[field.name] = parsers;
},
[]
);
Expand All @@ -167,11 +167,11 @@ export default <V extends FormValues = FormValues>({
let value = field.value as any;

if (isInputElement(field)) {
if (fieldParsersRef.current[name]?.valueAsNumber) {
if (fieldArgsRef.current[name]?.valueAsNumber) {
value = field.valueAsNumber;
return value;
}
if (fieldParsersRef.current[name]?.valueAsDate) {
if (fieldArgsRef.current[name]?.valueAsDate) {
value = field.valueAsDate;
return value;
}
Expand Down Expand Up @@ -796,7 +796,7 @@ export default <V extends FormValues = FormValues>({
}

if (fieldsRef.current[name] && !controllersRef.current[name]) {
const parse = fieldParsersRef.current[name]?.parse;
const parse = fieldArgsRef.current[name]?.parse;
const value = getNodeValue(name);

handleChangeEvent(name, parse ? parse(value) : value);
Expand Down Expand Up @@ -866,7 +866,7 @@ export default <V extends FormValues = FormValues>({
true
);

delete fieldParsersRef.current[name];
delete fieldArgsRef.current[name];
delete fieldValidatorsRef.current[name];
delete controllersRef.current[name];
});
Expand Down