-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features for the new IDE #526
Conversation
@LingDong- The Netlify deploy for pull requests seem not triggering. May this due to the repo transferring? |
Yes, it's strange that Netlify no longer deploys previews, yesterday it seems to be working fine The explorer looks great! Can we make the explorer window taller and output window less wide, meaning:
Thanks! And now that we have the explorer window, maybe we can even support creating and opening folders (zip upload), but that's more complex and for the future. This is looking so nice, that I'm thinking after we're done with the improvements, I can wrap it in an electron app, so we have our own native IDE :D |
It's almost done. Please check it out when you got some time! And maybe we need some tips on the pape for the auto-saving mechanism. |
👍👍Looking awesome! Love the explorer I see you changed |
Noticed too. However, I think the fixed hack is not ideal for buttons like "new" and "delete".
We can use grids. I will fix them another time. I need to get some sleep for the flight tmr ;) |
Despite the right floating part, I have finished most of the features for this PR.
Some idea for the future improvements
Let me know what you think about it! |
@antfu Thanks! I think I myself couldn't have done any better! All your improvement ideas sound good too. For the auto-complete part, the letters prefix were originally intended to hack Also, I just made a draft for the first chapter of the book. Sent an invite to you to the project :) |
I would like to do some improvements to the snippet site (and maybe try some online DB and move it out from glitch). The current snippets site seems to have some features broken. I have sent a request to collaborate on the glitch project. Please have a check. Thanks |
@antfu thanks, that would be awesome! |
Got it. Thanks. Will keep you up to date of the progress :) |
I have fixed some bugs and update the compiler for snippet site. On the other side, I am looking for some serverless db alternative that accessible in mainland China. https://www.bmob.cn/ or https://www.leancloud.cn/ might be some options (haven't tested yet) Also, I am wondering if we should embed the snippet site into the IDE since they share some similar features. Some ideas
|
Yeah. Sounds good. I like the idea with subdomain
That would be pretty cool! No idea how to do it though.
All sounds great. For showcases, we might be able to put it off until there are more snippets. By then we'll have a better idea of what people are submitting and better curate them. Judging from the look of their website, the second one looks slightly better. Bmob has a blurry logo right on top of their homepage... Eww!
|
Yeah. I thought this at the beginning. But there is editing functionality in snippets site and as we keep improving the IDE (contextual autocomplete, error underlines etc) it's hard to keep the builtin editor of snippets site up to date. Another way is that maybe we can the IDE embeddable that can be utilized in the snippet site and even other 3rd party websites. I think https://codepen.io/ is pretty similar to what we what to achieve in snippet site and it has an editor built-in might be a good reference.
I was thinking that we could save the result text/image on snippet publishing. This can make people better understand what's going on for the snippet without losing the performance. We should also add a paginate system for that as well. I prefer the second one as well :) Will try them later
Material Icons seems blocked in China. raw.githubusercontent.com is also blocked recently, I am curious how developers in China work 😂 iconify provides a great service that only loads the icons u used. and has a large collection of icons to use. And yes, it seems to work in China. |
I think making the IDE embeddable sounds like a great idea, and like you mentioned also useful for 3rd party. I wasn't previously aware of iconify, but after I saw you using it in the IDE, I thought it's awesome :) |
Btw I think we can apply for Netlify Open Source Plan which can create a team with unlimited members. If you are ok with it, I can add the badge on the site and fill the form :) |
I have done the out-souring, and they works perfectly. I will try to see how could they work together then. Sent you the invitation to the repos. https:/antfu/wenyan-ide https://wenyan-ide.netlify.com/ |
What do you think? :) I have made some progress to the embedding IDE, I think it's kinda ready to transfer to the org and setup ide.wy-lang.org 😃 As for the snippet site, I have tried both services a little and seem bmob is much more mature (than how it looks XD). I think I would probably go with that one first. And I do miss Firebase anyway. |
I think it's a great idea. I think it's basically the same as the donation system, where netlify donate a premium plan to us, and we put their ads on our site. I prefer the "Light Badge" one. The colored ones don't fit with our theme :) The embed thing looks nice! I know the style is still in progress, but I feel the title bars are too thick, since embed is supposed to be small thing on the page. In fact, I think we might even get rid of the bars. Just show a small triangle on top right corner for running.
Sure! |
I think we can probably add with another option |
I have updated the editor and demo. You can have a look when you go some free time :) |
👍Very Nice, thanks a lot! I think functionality-wise it's perfect, but Some small issues, likely related to browser, since it breaks differently on my chrome and safari :P
Chrome Version 79.0.3945.88 (Official Build) (64-bit) I totally understand you might not be able to reproduce these problems on your system/browser. In which case I can look into them when you're finished with the features :) |
Noticed too. I think I might be some performance limitation or something for iframe on Chrome. I will try to rewrite the mechanism for dragging the handlers to see if it solves the issue.
The dark mode issue probably due to the safari hack. The outdiv should set According to your description, the buttons in the demo seem to work in safari (surprisingly). It actually uses postMessages (which are the same as the output iframe). So iframe for output might be workable for safari. I am planning to get a macbook next month. Hope I can dive into it then. |
The iframe bug in safari is fixed in wenyan-lang/ide@f58b83e The problem is running I have changed the layout mechanism to css vars. The handler lag should be fixed too. Please check it out. |
Awesome, thanks a lot! Both iframe and handlebar work perfectly now. Nice problem solving with the iframe, I also saw src become empty, but couldn't figure out how come. BTW Congrats on getting your new macbook :) |
This comment has been minimized.
This comment has been minimized.
Will have a look tmr |
@antfu, What I meant was that previously, when it WASN'T working on Safari, src was empty, and I couldn't figure out how to fix it. That was two weeks ago. Today, now that you figured out the reason and totally fixed it, everything is working great :) |
Haha my bad. 😅 |
You can preview the changes on: (wait for Netlify building....)
Let me know what you think about it!
TODO
The
publish
button will not include in this PR