Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LingLongTa.wy 中國傳統繞口令 玲瓏塔 #576

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Create LingLongTa.wy 中國傳統繞口令 玲瓏塔 #576

merged 1 commit into from
Feb 7, 2020

Conversation

tony-aptx4869
Copy link
Contributor

GitHub:wenfeng0218
GMail:[email protected]

@LingDong-
Copy link
Member

Hi @wenfeng0218 I do like your new example, so sorry I didn't notice the PR when you opened it, I was busy working on a related project.

I do want to merge this, I think it would be a great addition to the examples. Unless there is another reason for you to close it?

One thing though, would you mind renaming the file so it uses snake case instead of camel case to conform with other examples? Perhaps linglong_tower.wy

Thank you very much!

@LingDong- LingDong- reopened this Feb 7, 2020
@tony-aptx4869
Copy link
Contributor Author

Hi @wenfeng0218 I do like your new example, so sorry I didn't notice the PR when you opened it, I was busy working on a related project.

I do want to merge this, I think it would be a great addition to the examples. Unless there is another reason for you to close it?

One thing though, would you mind renaming the file so it uses snake case instead of camel case to conform with other examples? Perhaps linglong_tower.wy

Thank you very much!

So sorry! I am not familiar using GitHub. The Web says "Some checks haven't completed yet", so I thought there were something went wrong.

I am so happy you like my example. I love Chinese traditional culture, including the Cross Talk, aka, 相聲. And thanks a lot for your advice about the file name, I will listen to you.

BTW. I do love the Wenyan-language you created. It's ... WOW!

@LingDong-
Copy link
Member

LingDong- commented Feb 7, 2020

Yeah it seems like a Github action's problem, adding a new example shouldn't be able to break any tests. Merging now to see what happens.

EDIT: Now renamed the example and added to the listing: af732b8

@LingDong- LingDong- merged commit 8b480cc into wenyan-lang:master Feb 7, 2020
@tony-aptx4869 tony-aptx4869 deleted the patch-1 branch February 8, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants