feat(core-react): add typings to index.d.ts for Container, Grid, & Cell #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morgantheplant
assigned jgbenito7, adamraider, wuweiweiwu, nicolelharrison and seimithwework
seimithwework
approved these changes
Sep 4, 2019
packages/core-react/index.d.ts
Outdated
| export type CellProps = { | ||
| push?: 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12; | ||
| span?: 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12; | ||
| } & React.HTMLProps<HTMLElement>;; |
There was a problem hiding this comment.
woops ;; but I'll fix this for you!
There was a problem hiding this comment.
good catch! Surprised this wasn't caught by a commit hook
packages/core-react/index.d.ts
Outdated
|
|
||
| declare const Cell: React.FC<CellProps>; | ||
|
|
||
| export { Container, Grid, TextField }; |
There was a problem hiding this comment.
this was intentional: #213 (comment) I am ok with exporting it though
seimithwework
force-pushed
the
mcp/grid_components
branch
from
1a81d9b
to
68ca24f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.weworkers.io/browse/WEB-815
adds typings for Container, Grid and Cell components