Ihor/ray core/rich dropdown component #252
Conversation
…, change. Placeholders and support of disabled, required, compact and other ray modificators
…roups disable support, related storybook entries
|
Looks like the icon is overlapping the drop down arrow
|
There was a problem hiding this comment.
Pls update your PR title to use conventional commits: https://www.conventionalcommits.org/en/v1.0.0/#summary
| @@ -0,0 +1,23 @@ | |||
| <div className="ray-dropdown"> | |||
There was a problem hiding this comment.
These .html files need to be valid html. These look like JSX, make sure you convert things like className to class, and htmlFor to for
There was a problem hiding this comment.
thanks. copy-paste plays bad role
| Pokemon | ||
| </label> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Make sure all HTML is valid (not JSX) and please fix the indentation
| transition-timing-function: ease-in; | ||
| transition-property: height, max-height; | ||
| } | ||
| &-list { |
There was a problem hiding this comment.
There's still Coverage decreased (-4.5%) , could you add more tests? You can view the coveralls report to see which lines need coverage
There was a problem hiding this comment.
added more tests
docs/components/dropdown.md
Outdated
|
|
||
| | Method | Params | Description | | ||
| | -------------------------- | -------------------- | ------------------------------------ | | ||
| | `Select.createAll` | `HTMLElement:Object` | create all instances in document | |
There was a problem hiding this comment.
should be Dropdown.* here?
There was a problem hiding this comment.
Looks good, but no keyboard navigation support?
Yeah we split it out on primary and secondary features. Keyboard nav is secondary. We wan't to merge it to ray to unblock and finish GROW-9590. Btw custom language dropdown at footer of wework.com site which was used as prototype also doesn't have keyboard nav
delete-merged-branch
bot
deleted the
ihor/ray-core/rich-dropdown-component
branch
Dropdown component for ray framework. When default is not enough. Works as wrapper-enchancer for component. Fallback as
.ray-selectif JS is not applied for some reason.https://deploy-preview-252--ray-docs.netlify.com/