fix(select): don't move label on focus/active #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraider
suggested changes
May 12, 2019
it sure does. that placeholder does complicate things. do we really need it? |
|
Attempt at fixing placeholder mode across browsers -- 5aa321b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #88
The current Select focus/active implementation moves the label up when a select is activated, but if no selection is made (and user clicks off of the select), then the label remains "activated" and only returns back to normal when the select completely loses focus. This change makes it so that the label only moves up if a selection is made.
Current behavior
New proposed behavior