Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): add space around arrow so doesn't overlap #164

Merged
merged 3 commits into from
Jul 9, 2019
Merged

fix(select): add space around arrow so doesn't overlap #164

merged 3 commits into from
Jul 9, 2019

Conversation

cmugla
Copy link

@cmugla cmugla commented Jul 9, 2019 •
edited
Loading

I don't think there is a way to do this with pure css to show an ellipsis.

BEFORE:
Screen Shot 2019-07-09 at 11 26 07 AM

AFTER:
Screen Shot 2019-07-09 at 11 25 51 AM

@cmugla cmugla requested a review from a team as a code owner July 9, 2019 15:32
@adamraider
Copy link
Contributor

Nice, can you add a story so we can visually track?

adamraider
adamraider approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@adamraider adamraider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope

@cmugla cmugla merged commit 8bb6381 into master Jul 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the cg/select-overflow branch July 9, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraider adamraider adamraider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmugla @adamraider