feat(chip): add / modify chip component #181
Conversation
|
Should probably add keyboard navigation (make sure focus states work and ability to toggle with space bar) |
| import html from 'nanohtml'; | ||
| import Chip from '../../src/components/chip'; | ||
|
|
||
| function triggerEvent(el, type) { |
There was a problem hiding this comment.
cant remember if this is used elsewhere but we maaaay want to abstract into a util, definitely not blocking on this
|
@adamraider added keyboard nav support! thanks for catching that |
| } | ||
|
|
||
| _bindEventListeners() { | ||
| this._root.addEventListener('mousedown', this.onClick); |
There was a problem hiding this comment.
this came up for another component I can't quite remember, but should we add this for touchstart as well? Did you test on your phone?
There was a problem hiding this comment.
great catch! it looks like both the touch events and click events retain hover styling when clicking on mobile. so i added the hover style to non mobile screens only.
here's a lil demo https://cl.ly/16bf6c68733d
| </div> | ||
| </div> | ||
| ); | ||
| }); | ||
| storiesOf('Chip', module).add('micro', () => { |
There was a problem hiding this comment.
nit: you can chain these .add statements
A continuation of #10 that adds icon support for chips
https://cl.ly/554d75534195