Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is non-GET/POST stored #1524

Closed
annevk opened this issue Jul 8, 2016 · 2 comments · Fixed by #6315
Closed

Where is non-GET/POST stored #1524

annevk opened this issue Jul 8, 2016 · 2 comments · Fixed by #6315

Comments

@annevk
Copy link
Member

annevk commented Jul 8, 2016

Another question for @smaug---- and @majido. The HTML Standard hints at some point that history session entries store whether the URL was retrieved using GET or POST.

This information is also used when a document is reloaded (a prompt shows up to ask the user if they're sure they want to submit the data again). Would we then get it from the session history's current entry or is it also stored elsewhere?

@smaug----
Copy link

"also stored"? Is there a thing stored elsewhere?

Anyhow, Gecko stores the post data in session history entry
http://searchfox.org/mozilla-central/rev/f43c9e0ffa92e72dbdbcbf57eecf04a43d46da63/docshell/shistory/nsSHEntry.h#56
and that is used when reloading
http://searchfox.org/mozilla-central/rev/f43c9e0ffa92e72dbdbcbf57eecf04a43d46da63/docshell/base/nsDocShell.cpp#12361
Necko then uses "POST" method if such post data is used.

@annevk
Copy link
Member Author

annevk commented Jul 8, 2016

"also stored"? Is there a thing stored elsewhere?

I was just curious if I missed something. I suspect this can probably all live on the session history entry as "form data" (as it's called now). That's probably good enough although maybe not as there's also the correct Content-Type header to set, Referer might have to be reused, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants