Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align cross-origin [[Delete]] with implementations #1728

Merged
merged 4 commits into from
Sep 14, 2016
Merged

Align cross-origin [[Delete]] with implementations #1728

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b121e9
Align cross-origin [[Delete]] with implementations
annevk Aug 30, 2016
9b37a4b
use SecurityError for [[Delete]]
annevk Sep 13, 2016
cf0231b
make [[DefineOwnProperty]] and [[Set]] (through CrossOriginSet) throw…
annevk Sep 13, 2016
61bf35c
simplify CrossOriginSet
annevk Sep 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 29 additions & 22 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78365,21 +78365,17 @@ console.assert(iframeWindow.frameElement === null);
<li><p>Assert: <var>desc</var> is not undefined.</p></li>

<li>
<p>If <span>IsAccessorDescriptor</span>(<var>desc</var>) is true, then:</p>
<p>If <var>desc</var>.[[Set]] is present and its value is not undefined, then:

<ol>
<li><p>Let <var>setter</var> be <var>desc</var>.[[Set]].</p></li>

<li><p>If <var>setter</var> is undefined, return false.</p></li>

<li><p>Perform ? <span>Call</span>(<var>setter</var>, <var>Receiver</var>,
«<var>V</var>»).</p></li>

<li><p>Return true.</p></li>
</ol>
</li>

<li><p>Return false.</p></li>
<li><p>Throw a <span>"<code>SecurityError</code>"</span> <code>DOMException</code>.</p></li>
</ol>

<h5><dfn>CrossOriginOwnPropertyKeys</dfn> ( <var>O</var> )</h5>
Expand Down Expand Up @@ -79329,22 +79325,28 @@ callback <dfn>FrameRequestCallback</dfn> = void (<span>DOMHighResTimeStamp</span
)</h4>

<ol>
<li><p>If <var>P</var> is an <span>array index property name</span>, return false.</p></li>

<li><p>Let <var>W</var> be the value of the
[[<span data-x="concept-windowproxy-window">Window</span>]] internal slot of
<b>this</b>.</p></li>

<li>
<p>If <span>IsPlatformObjectSameOrigin</span>(<var>W</var>) is true, then return ?
<span>OrdinaryDefineOwnProperty</span>(<var>W</var>, <var>P</var>, <var>Desc</var>).</p>
<p>If <span>IsPlatformObjectSameOrigin</span>(<var>W</var>) is true, then:

<p class="note">This is a <span>willful violation</span> of the JavaScript specification's
<span>invariants of the essential internal methods</span> to maintain compatibility with
existing Web content. See <a href="https:/tc39/ecma262/issues/672">tc39/ecma262
issue #672</a> for more information. <ref spec=JAVASCRIPT></p>
<ol>
<li><p>If <var>P</var> is an <span>array index property name</span>, return false.</p></li>

<li><p>Return false.</p></li>
<li>
<p>Return ? <span>OrdinaryDefineOwnProperty</span>(<var>W</var>, <var>P</var>,
<var>Desc</var>).</p>

<p class="note">This is a <span>willful violation</span> of the JavaScript specification's
<span>invariants of the essential internal methods</span> to maintain compatibility with
existing Web content. See <a href="https:/tc39/ecma262/issues/672">tc39/ecma262
issue #672</a> for more information. <ref spec=JAVASCRIPT></p>
</li>
</ol>

<li><p>Throw a <span>"<code>SecurityError</code>"</span> <code>DOMException</code>.</p></li>
</ol>

<h4 id="windowproxy-get">[[Get]] ( <var>P</var>, <var>Receiver</var> )</h4>
Expand Down Expand Up @@ -79380,16 +79382,21 @@ callback <dfn>FrameRequestCallback</dfn> = void (<span>DOMHighResTimeStamp</span
<h4 id="windowproxy-delete">[[Delete]] ( <var>P</var> )</h4>

<ol>
<li><p>If <var>P</var> is an <span>array index property name</span>, return false.</p></li>

<li><p>Let <var>W</var> be the value of the
[[<span data-x="concept-windowproxy-window">Window</span>]] internal slot of
<b>this</b>.</p></li>

<li><p>If <span>IsPlatformObjectSameOrigin</span>(<var>W</var>) is true, then return ?
<span>OrdinaryDelete</span>(<var>W</var>, <var>P</var>).</p></li>
<li>
<p>If <span>IsPlatformObjectSameOrigin</span>(<var>W</var>) is true, then:

<li><p>Return false.</p></li>
<ol>
<li><p>If <var>P</var> is an <span>array index property name</span>, then return
false.</p></li>

<li><p>Return ? <span>OrdinaryDelete</span>(<var>W</var>, <var>P</var>).</p></li>
</ol>

<li><p>Throw a <span>"<code>SecurityError</code>"</span> <code>DOMException</code>.</p></li>
</ol>

<h4 id="windowproxy-ownpropertykeys">[[OwnPropertyKeys]] ( )</h4>
Expand Down Expand Up @@ -81742,7 +81749,7 @@ State: &lt;OUTPUT NAME=I>1&lt;/OUTPUT> &lt;INPUT VALUE="Increment" TYPE=BUTTON O
</ol>
</li>

<li><p>Return false.</p></li>
<li><p>Throw a <span>"<code>SecurityError</code>"</span> <code>DOMException</code>.</p></li>
</ol>

<h5 id="location-get">[[Get]] ( <var>P</var>, <var>Receiver</var> )</h5>
Expand Down Expand Up @@ -81771,7 +81778,7 @@ State: &lt;OUTPUT NAME=I>1&lt;/OUTPUT> &lt;INPUT VALUE="Increment" TYPE=BUTTON O
<li><p>If <span>IsPlatformObjectSameOrigin</span>(<b>this</b>) is true, then return ?
<span>OrdinaryDelete</span>(<b>this</b>, <var>P</var>).</p></li>

<li><p>Return false.</p></li>
<li><p>Throw a <span>"<code>SecurityError</code>"</span> <code>DOMException</code>.</p></li>
</ol>

<h5 id="location-ownpropertykeys">[[OwnPropertyKeys]] ( )</h5>
Expand Down