Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins from system directories #135

Closed
mruszczyk opened this issue Feb 20, 2017 · 6 comments
Closed

Allow plugins from system directories #135

mruszczyk opened this issue Feb 20, 2017 · 6 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: high High priority Regression Bug that breaks functionality known to work in previous releases Sprintable Small enough to sprint on
Milestone

Comments

@mruszczyk
Copy link
Contributor

Right now all of the logging plugins must be installed to either $XDG_DATA_HOME/whipper/plugins or $HOME/.local/share/whipper/plugins, both of which are (generally) in the users home directory. This is fine for users wishing to install plugins themselves but the purpose of system wide packages is to install for all users on a system so requiring packaged binaries to be placed into a home directory defeats that purpose.

In order to make packaging whipper logging plugins easier I suggest whipper also check system directories for plugins.

@IvanDSM
Copy link

IvanDSM commented Feb 21, 2017

Agreed, very important feature.

@RecursiveForest
Copy link
Contributor

I approve of this suggestion.

@JoeLametta
Copy link
Collaborator

Are there any system "standard" paths for storing the plugins? (something like XDG ones)

@JoeLametta JoeLametta reopened this Mar 5, 2017
@mruszczyk
Copy link
Contributor Author

I mentioned this on irc this morning, I think the obvious answer is the python2 sitelib, as far as how to locate that on any given system I'm unsure. I know on my system is it /usr/lib/python2.X/site-packages but there may be a way to check for the sitelib and check within that directory.

http://stackoverflow.com/questions/122327/how-do-i-find-the-location-of-my-python-site-packages-directory

@Freso
Copy link
Member

Freso commented Apr 28, 2017

morituri at least worked fine if you installed loggers to Python's site-packages directory. Has this really been broken by whipper? (I don't think I've used custom loggers with whipper yet, so I wouldn't know.)

@JoeLametta JoeLametta added this to the 1.0 milestone Aug 15, 2017
@MerlijnWajer MerlijnWajer self-assigned this Feb 9, 2018
@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Accepted Accepted issue on our roadmap Priority: high High priority Sprintable Small enough to sprint on Needed: patch A pull request is required Regression Bug that breaks functionality known to work in previous releases and removed enhancement labels Nov 12, 2018
@JoeLametta JoeLametta added the Status: in progress Issue/pull request which is currently being worked on label Dec 12, 2018
@JoeLametta
Copy link
Collaborator

WIP in #348...

JoeLametta added a commit that referenced this issue Dec 14, 2018
@JoeLametta JoeLametta removed Needed: patch A pull request is required Status: in progress Issue/pull request which is currently being worked on labels Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: high High priority Regression Bug that breaks functionality known to work in previous releases Sprintable Small enough to sprint on
Projects
None yet
Development

No branches or pull requests

6 participants