Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify media type in log file (ie CD vs CD-R) #137

Closed
solstice0 opened this issue Mar 4, 2017 · 4 comments
Closed

Identify media type in log file (ie CD vs CD-R) #137

solstice0 opened this issue Mar 4, 2017 · 4 comments
Labels
Accepted Accepted issue on our roadmap Feature New feature
Milestone

Comments

@solstice0
Copy link

Not sure if it is technically possible, but it could be a useful feature for a variety of reasons.

@JoeLametta JoeLametta added this to the 101010 milestone Mar 5, 2017
@JoeLametta
Copy link
Collaborator

Not sure if it is technically possible, but it could be a useful feature for a variety of reasons.

Yeah, I'll check if it can be done.

@JoeLametta
Copy link
Collaborator

When issuing:

cdrdao disk-info -v0

There's a line which reports if the inserted medium is a a CD-R or n/a in case it isn't. So, every time we get the following reply: CD-R medium : n/a, we can mark the disc as a pressed CD, else as a CD-R.

I don't know if that detection is 100% accurate but is should be quite reliable as pressed discs don't have the ATIP (which is always included in writable CD medias).

@Freso
Copy link
Member

Freso commented Apr 28, 2017

If we're checking for "CD-R", that's what we should report on (ie., "CD-R: True/False"). There are a number of different types of CDs (https://musicbrainz.org/doc/Release/Format), and claiming "Type: CD" vs. "Type: CD-R" could potentially be misleading, IMHO.

@JoeLametta
Copy link
Collaborator

Completed?

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Feature New feature and removed enhancement labels Nov 12, 2018
@JoeLametta JoeLametta modified the milestones: backlog, 1.0 Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants