Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with finding offset #182

Closed
parkerlreed opened this issue Aug 12, 2017 · 16 comments
Closed

Issues with finding offset #182

parkerlreed opened this issue Aug 12, 2017 · 16 comments
Labels
Bug Generic bug: can be used together with more specific labels Upstream Bug The issue is a result of an upstream bug

Comments

@parkerlreed
Copy link

whipper-git 0.5.1.r45.g3f248bf-1
Arch x86_64

[parker@e55 Music]$ whipper drive analyze
cdparanoia can defeat the audio cache on this drive.
Adding drive cache behaviour to configuration file.
[parker@e55 Music]$ whipper drive list
drive: /dev/cdrom, vendor: msi     , model: DVD-RW DH24AS   , release: LM21
       No read offset found.  Run 'whipper offset find'
       Can defeat audio cache: True

I tried the offset of 6 as mentioned in the database but that fails.

I let it scan for offsets and it's on a seemingly unending journey

[parker@e55 Music]$ whipper offset find -o 6
Checking device /dev/sr0
Trying read offset 6 ...
No matching offset found.                    
Consider trying again with a different disc.
[parker@e55 Music]$ whipper offset find 
Checking device /dev/sr0
Trying read offset 6 ...
Trying read offset 48 ...                    
Trying read offset 102 ...                   
Trying read offset 667 ...                   
Trying read offset 12 ...                    
Trying read offset 30 ...                    
Trying read offset 618 ...                   
Trying read offset 594 ...                   
Trying read offset 738 ...                   
Ripping track 1 with read offset 738  86 %
@RecursiveForest
Copy link
Contributor

RecursiveForest commented Aug 12, 2017 •
edited
Loading

cdparanoia doesn't force overreading into the lead-out on drives that don't support doing so. This will cause issues verifying the rip offset on the last track. the AUR package cdparanoia-overread adds a workaround for this. Try replacing cdparanoia with this package and running ripping with ... rip -x.

If that doesn't work, please try running with the environment variables WHIPPER_DEBUG=debug and WHIPPER_LOGFILE=whipper.log and uploading the resulting logfile.

@parkerlreed
Copy link
Author

With cdparanoia-overread do I just need to manually specify my offset as 6?

@parkerlreed
Copy link
Author

parkerlreed commented Aug 12, 2017 •
edited
Loading

Seems to go fine until the last track

[parker@e55 Music]$ whipper cd rip -x
Using configured read offset 6
Checking device /dev/sr0
CDDB disc id: 860a020c
MusicBrainz disc id Zu_tQ7K_EBKJtpLD0jNanb5TIHs-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+12+192357+150+11040+23089+39169+53476+71528+90501+104785+121981+143657+158280+172839&tracks=12&id=Zu_tQ7K_EBKJtpLD0jNanb5TIHs-
Disc duration: 00:42:42.760, 12 audio tracks

Matching releases:

Artist  : Garth Brooks
Title   : Gunslinger (Target Exclusive)
Duration: 00:42:41.000
URL     : https://musicbrainz.org/release/adb68030-63b0-4c82-903d-a4e1ebc88953
Release : adb68030-63b0-4c82-903d-a4e1ebc88953
Type    : Album

Creating output directory ./album/Garth Brooks - Gunslinger (Target Exclusive)
Ripping track 1 of 12: 01. Garth Brooks - Honky-Tonk Somewhere.flac
Checksums match for track 1               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 2 of 12: 02. Garth Brooks - Weekend.flac
Checksums match for track 2               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 3 of 12: 03. Garth Brooks - Ask Me How I Know.flac
Checksums match for track 3               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 4 of 12: 04. Garth Brooks - Baby, Let's Lay Down and Dance.flac
Checksums match for track 4               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 5 of 12: 05. Garth Brooks - He Really Loves You.flac
Checksums match for track 5               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 6 of 12: 06. Garth Brooks - Whiskey to Wine.flac
Checksums match for track 6               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 7 of 12: 07. Garth Brooks - Bang! Bang!.flac
Checksums match for track 7               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 8 of 12: 08. Garth Brooks - Pure Adrenaline.flac
Checksums match for track 8               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 9 of 12: 09. Garth Brooks - 8teen.flac
Checksums match for track 9               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 10 of 12: 10. Garth Brooks - Sugarcane.flac
Checksums match for track 10               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 11 of 12: 11. Garth Brooks - Cowboys and Friends.flac
Checksums match for track 11               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 12 of 12: 12. Garth Brooks - Friends In Low Places - 25th Anniversary Edition.flac
WARNING:whipper.program.cdparanoia:file size 45875244 did not match expected size 45906380
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
Ripping track 12 of 12 (try 2): 12. Garth Brooks - Friends In Low Places - 25th Anniversary Edition.flac
WARNING:whipper.program.cdparanoia:file size 45875244 did not match expected size 45906380
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
Ripping track 12 of 12 (try 3): 12. Garth Brooks - Friends In Low Places - 25th Anniversary Edition.flac
WARNING:whipper.program.cdparanoia:file size 45875244 did not match expected size 45906380
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference

I'll get some output with the debug options after this times out or I cancel it heh.

EDIT: Yep no go

CRITICAL:whipper.command.cd:Giving up on track 12 after 5 times
Traceback (most recent call last):               
  File "/usr/bin/whipper", line 11, in <module>
    load_entry_point('whipper==0.5.1', 'console_scripts', 'whipper')()
  File "/usr/lib/python2.7/site-packages/whipper/command/main.py", line 32, in main
    ret = cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper/command/basecommand.py", line 124, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper/command/basecommand.py", line 124, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper/command/cd.py", line 213, in do
    self.doCommand()
  File "/usr/lib/python2.7/site-packages/whipper/command/cd.py", line 528, in doCommand
    ripIfNotRipped(i + 1)
  File "/usr/lib/python2.7/site-packages/whipper/command/cd.py", line 464, in ripIfNotRipped
    "track can't be ripped. "
RuntimeError: track can't be ripped. Rip attempts number is equal to 'MAX_TRIES'

I'll get some debug output now.

@parkerlreed
Copy link
Author

Here's the full log. It ended at the same result of failing to rip track 12 5 times. http://ix.io/z6e

@MerlijnWajer
Copy link
Collaborator

Can you try it with libcdio's cd-paranoia?

See #175

@MerlijnWajer
Copy link
Collaborator

Also, with the overread cdparanoia, you also need to specify -x to cdparanoia, and there's no flag in whipper to do that right now.

@parkerlreed
Copy link
Author

Seem's I already had libcdio-paranoia installed (Actually both)

libcdio-paranoia 10.2+0.94+1-2
libcdio 0.94-2
cdparanoia-overread 10.2-1

Could something possibly be conflicting? (No conflicting files so I assume whipper is just picking one of them)

@MerlijnWajer
Copy link
Collaborator

Whipper currently always just takes 'cdparanoia'. I will try to make a PR that changes this ASAP.

@RecursiveForest
Copy link
Contributor

RecursiveForest commented Aug 14, 2017 •
edited
Loading

Also, with the overread cdparanoia, you also need to specify -x to cdparanoia, and there's no flag in whipper to do that right now.

The option -x to whipper cd rip adds --force-overread (the long form of cdparanoia's new -x), so I don't think that's the issue.

@parkerlreed did it work using cd-paranoia?

@MerlijnWajer I'm in a position where I have a lot more time on my hands now, so if you need to hand off something let me know. I have a local branch where I've refactored most of the accuraterip code (as part of the larger cleanups), and am going to spend this week & weekend getting ARv2 support finalised and PR'd. edit: I know this venue isn't the right comment thread for the above comment. shrugs

@parkerlreed
Copy link
Author

parkerlreed commented Aug 14, 2017 •
edited
Loading

@RecursiveForest The log I posted above was from paranoia-overread.

EDIT: If you were referring to trying with libcdio, I don't know exactly what to change in the whipper code to make it do that. Was waiting for a PR to try it out.

@JoeLametta
Copy link
Collaborator

The log I posted above was from paranoia-overread.

Could you try ripping again using whipper with cdparanoia-overread without the -x switch then report the outcome? (just like this:)

whipper cd rip

Thanks

@parkerlreed
Copy link
Author

Will do. I'll be back at that computer in a couple hours.

@parkerlreed
Copy link
Author

Sorry for the late response. Without the -x it goes a lot better but says every file failed the match to the database. Could this be down to just needing to wait for the accuraterip changes?

http://ix.io/zjL

[parker@e55 Music]$ WHIPPER_DEBUG=debug WHIPPER_LOGFILE=whipper.log whipper cd rip
Using configured read offset 6
Checking device /dev/sr0
CDDB disc id: 860a020c
MusicBrainz disc id Zu_tQ7K_EBKJtpLD0jNanb5TIHs-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+12+192357+150+11040+23089+39169+53476+71528+90501+104785+121981+143657+158280+172839&tracks=12&id=Zu_tQ7K_EBKJtpLD0jNanb5TIHs-
Disc duration: 00:42:42.760, 12 audio tracks

Matching releases:

Artist  : Garth Brooks
Title   : Gunslinger (Target Exclusive)
Duration: 00:42:41.000
URL     : https://musicbrainz.org/release/adb68030-63b0-4c82-903d-a4e1ebc88953
Release : adb68030-63b0-4c82-903d-a4e1ebc88953
Type    : Album

Creating output directory ./album/Garth Brooks - Gunslinger (Target Exclusive)
Ripping track 1 of 12: 01. Garth Brooks - Honky-Tonk Somewhere.flac
Checksums match for track 1               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 2 of 12: 02. Garth Brooks - Weekend.flac
Checksums match for track 2               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 3 of 12: 03. Garth Brooks - Ask Me How I Know.flac
Checksums match for track 3               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 4 of 12: 04. Garth Brooks - Baby, Let's Lay Down and Dance.flac
Checksums match for track 4               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 5 of 12: 05. Garth Brooks - He Really Loves You.flac
Checksums match for track 5               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 6 of 12: 06. Garth Brooks - Whiskey to Wine.flac
Checksums match for track 6               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 7 of 12: 07. Garth Brooks - Bang! Bang!.flac
Checksums match for track 7               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 8 of 12: 08. Garth Brooks - Pure Adrenaline.flac
Checksums match for track 8               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 9 of 12: 09. Garth Brooks - 8teen.flac
Checksums match for track 9               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 10 of 12: 10. Garth Brooks - Sugarcane.flac
Checksums match for track 10               
Peak level: 93.34% 
Rip quality: 100.00%
Ripping track 11 of 12: 11. Garth Brooks - Cowboys and Friends.flac
Checksums match for track 11               
Peak level: 93.33% 
Rip quality: 100.00%
Ripping track 12 of 12: 12. Garth Brooks - Friends In Low Places - 25th Anniversary Edition.flac
Checksums match for track 12               
Peak level: 93.33% 
Rip quality: 100.00%
AccurateRip URL http://www.accuraterip.com/accuraterip/6/e/4/dBAR-012-001204e6-00abb537-860a020c.bin
2 AccurateRip reponses found
Track  1: rip NOT accurate (max confidence     17) [f6c375f3], DB [8ef1ab26]
Track  2: rip NOT accurate (max confidence     17) [49488d8c], DB [d24a260b]
Track  3: rip NOT accurate (max confidence     17) [6c9d76a1], DB [f735a656]
Track  4: rip NOT accurate (max confidence     17) [b8c1e79c], DB [f221b0e4]
Track  5: rip NOT accurate (max confidence     17) [4c077137], DB [630029e0]
Track  6: rip NOT accurate (max confidence     17) [c84fa1f2], DB [62c26a45]
Track  7: rip NOT accurate (max confidence     17) [62dc05ba], DB [be722e2f]
Track  8: rip NOT accurate (max confidence     16) [68cc0875], DB [cdff2ad4]
Track  9: rip NOT accurate (max confidence     16) [ef77c711], DB [1281d196]
Track 10: rip NOT accurate (max confidence     16) [aa7c93a7], DB [c6d0f708]
Track 11: rip NOT accurate (max confidence     16) [d921e6d2], DB [1db92315]
Track 12: rip NOT accurate (max confidence     16) [0670acbe], DB [008853b4]

Interestingly enough if I check the V1 database the files seem to match.

[parker@e55 Music]$ accuraterip-checksum --accuraterip-v1 album/Garth\ Brooks\ -\ Gunslinger\ \(Target\ Exclusive\)/01.\ Garth\ Brooks\ -\ Honky-Tonk\ Somewhere.flac 1 12
F6C375F3

@RecursiveForest
Copy link
Contributor

Do the v2 checksums from the ripped tracks match the database?

@parkerlreed
Copy link
Author

How do I tell exactly? The whipper log only seemed to check V1.

Log created by: whipper 0.5.1 (internal logger)
Log creation date: 2017-08-21T02:18:23Z

Ripping phase information:
  Drive: msi     DVD-RW DH24AS    (revision LM21)
  Defeat audio cache: Yes
  Read offset correction: +6
  Overread into lead-out: No
  Gap detection: cdrdao 1.2.3
  CD-R detected: No

CD metadata:
  Album: Garth Brooks - Gunslinger (Target Exclusive)
  CDDB Disc ID: 860a020c
  MusicBrainz Disc ID: Zu_tQ7K_EBKJtpLD0jNanb5TIHs-
  MusicBrainz lookup url: https://musicbrainz.org/cdtoc/attach?toc=1+12+192357+150+11040+23089+39169+53476+71528+90501+104785+121981+143657+158280+172839&tracks=12&id=Zu_tQ7K_EBKJtpLD0jNanb5TIHs-

TOC:
  01:
    Start: 00:00:00
    Length: 02:25:15
    Start sector: 0
    End sector: 10889

  02:
    Start: 02:25:15
    Length: 02:40:49
    Start sector: 10890
    End sector: 22938

  03:
    Start: 05:05:64
    Length: 03:34:30
    Start sector: 22939
    End sector: 39018

  04:
    Start: 08:40:19
    Length: 03:10:57
    Start sector: 39019
    End sector: 53325

  05:
    Start: 11:51:01
    Length: 04:00:52
    Start sector: 53326
    End sector: 71377

  06:
    Start: 15:51:53
    Length: 04:12:73
    Start sector: 71378
    End sector: 90350

  07:
    Start: 20:04:51
    Length: 03:10:34
    Start sector: 90351
    End sector: 104634

  08:
    Start: 23:15:10
    Length: 03:49:21
    Start sector: 104635
    End sector: 121830

  09:
    Start: 27:04:31
    Length: 04:49:01
    Start sector: 121831
    End sector: 143506

  10:
    Start: 31:53:32
    Length: 03:14:73
    Start sector: 143507
    End sector: 158129

  11:
    Start: 35:08:30
    Length: 03:14:09
    Start sector: 158130
    End sector: 172688

  12:
    Start: 38:22:39
    Length: 04:20:18
    Start sector: 172689
    End sector: 192206

Tracks:
  01:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/01. Garth Brooks - Honky-Tonk Somewhere.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 3.2 X
    Extraction quality: 100.00 %
    Test CRC: 6903F991
    Copy CRC: 6903F991
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  02:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/02. Garth Brooks - Weekend.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 3.4 X
    Extraction quality: 100.00 %
    Test CRC: E338566B
    Copy CRC: E338566B
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  03:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/03. Garth Brooks - Ask Me How I Know.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 3.8 X
    Extraction quality: 100.00 %
    Test CRC: 8B861185
    Copy CRC: 8B861185
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  04:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/04. Garth Brooks - Baby, Let's Lay Down and Dance.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 3.9 X
    Extraction quality: 100.00 %
    Test CRC: F2662795
    Copy CRC: F2662795
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  05:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/05. Garth Brooks - He Really Loves You.flac
    Peak level: 0.933350
    Pre-emphasis: No
    Extraction speed: 4.3 X
    Extraction quality: 100.00 %
    Test CRC: 36BE8B63
    Copy CRC: 36BE8B63
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  06:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/06. Garth Brooks - Whiskey to Wine.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 4.7 X
    Extraction quality: 100.00 %
    Test CRC: 796152E9
    Copy CRC: 796152E9
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  07:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/07. Garth Brooks - Bang! Bang!.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 4.8 X
    Extraction quality: 100.00 %
    Test CRC: 4CFCE87A
    Copy CRC: 4CFCE87A
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  08:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/08. Garth Brooks - Pure Adrenaline.flac
    Peak level: 0.933350
    Pre-emphasis: No
    Extraction speed: 5.0 X
    Extraction quality: 100.00 %
    Test CRC: FC9260C8
    Copy CRC: FC9260C8
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  09:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/09. Garth Brooks - 8teen.flac
    Peak level: 0.933350
    Pre-emphasis: No
    Extraction speed: 5.2 X
    Extraction quality: 100.00 %
    Test CRC: 7F1E2DC8
    Copy CRC: 7F1E2DC8
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  10:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/10. Garth Brooks - Sugarcane.flac
    Peak level: 0.933350
    Pre-emphasis: No
    Extraction speed: 5.4 X
    Extraction quality: 100.00 %
    Test CRC: 13D85603
    Copy CRC: 13D85603
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  11:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/11. Garth Brooks - Cowboys and Friends.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 5.5 X
    Extraction quality: 100.00 %
    Test CRC: 34C37612
    Copy CRC: 34C37612
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

  12:
    Filename: ./album/Garth Brooks - Gunslinger (Target Exclusive)/12. Garth Brooks - Friends In Low Places - 25th Anniversary Edition.flac
    Peak level: 0.933319
    Pre-emphasis: No
    Extraction speed: 6.0 X
    Extraction quality: 100.00 %
    Test CRC: E8DD8BFF
    Copy CRC: E8DD8BFF
    AccurateRip V1:
      Result: Track not present in AccurateRip database
    Status: Copy OK

Conclusive status report:
  AccurateRip summary: None of the tracks are present in the AccurateRip database
  Health status: No errors occurred
  EOF: End of status report

SHA-256 hash: B5807003C081F396BF274B4D5E6E3EC74902239EEA69B2A0DC33E877A3038475

@parkerlreed
Copy link
Author

Seems to be working great with 2 drives now

Checking device /dev/sr0
Trying read offset 6 ...
Offset of device is likely 6, confirming ...

Already had a a 100% RIP from one and testing offset of the other right now.

@JoeLametta JoeLametta added the Bug Generic bug: can be used together with more specific labels label Feb 2, 2018
@JoeLametta JoeLametta added the Upstream Bug The issue is a result of an upstream bug label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Generic bug: can be used together with more specific labels Upstream Bug The issue is a result of an upstream bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RecursiveForest @MerlijnWajer @parkerlreed @JoeLametta