-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't find accuraterip-checksum binary in morituri-uninstalled mode #47
Comments
Presuming that morituri-uninstalled sets a PYTHONPATH, simply making sure that it either sets the PATH properly or installs accuraterip-checksum to bin/ should do the trick. I'll see what I can do to fix it. |
Presumably the problem is that automake will only move the binary to the right bin folder when 'make install' is issued. So one fix would be for morituri-uninstalled to add the src/ dir to the PATH variable, or otherwise ensure that somehow accuraterip-checksum ends up in the bin/ folder, which actually issuing make install. That is kind of tricky. |
With the change to setuptools, the nature of this bug has also changed a bit. Right now there are no provisions for automatically installing accuraterip-checksum anywhere from setuptools: you have to The simplest and most canonical approach is to either build arc with simple There is also the option of having setuptools handle the arc depedency (either by invoking |
So what do we want to do here? I'm in favour of closing the bug and doing nothing, as the documentation covers what one should do in this circumstance. |
Yeah maybe it can also be mentioned in the README (running uninstalled OR backward incompatible changes). |
Isn't it possible to have setuptools just build the binary when running setup.py? That'd be similar to 'make' without 'make install'. |
It is, but since you'd have to handle the install yourself we might as well let the user run |
Packaging question: is accuraterip-checksum a hard/optional dependency of whipper? It is not listed in README#Requirements, only mentioned later as a bundled dep (which is not built automatically anymore since the move to setuptools, if I understand correctly). |
Yes, please package it. It is not optional in the sense that our current code expects it to be installed - there is no fallback to the gst version. Can't setuptools also issue make, or perhaps compile the binary automatically? I think setuptools had ways to compile C code as well, so we can also use that instead of the makefile. |
The best would be to depend on the actual packaged accuraterip-checksum, eventually while trying harder to get leo-bogert/accuraterip-checksum#3 accepted or proposing this patch to respective accuraterip-checksum package maintainers. |
In morituri-uninstalled mode, I am now getting
This is fixed by copying the accuraterip-checksum binary to the bin directory. Trouble is, I can't figure out how to get the build system to do that.
The text was updated successfully, but these errors were encountered: