Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong status code when giving up #57

Closed
thomas-mc-work opened this issue Oct 29, 2016 · 3 comments
Closed

wrong status code when giving up #57

thomas-mc-work opened this issue Oct 29, 2016 · 3 comments
Labels
Bug Generic bug: can be used together with more specific labels
Milestone
1.0

Comments

@thomas-mc-work
Copy link
Contributor

thomas-mc-work commented Oct 29, 2016 •
edited
Loading

When I get this error message:

Calculating CRC (6 of 7) ...  99 %                 
Calculating CRC (6 of 7) ... 100 %                 

Calculating CRC (6 of 7) ...   0 %                 
Calculating peak level (7 of 7) ...   0 %          
Calculating peak level (7 of 7) ...   0 %          
ERROR [18950] "rip"                            rip               Okt 29 13:04:04      Giving up on track 15 after 5 times (morituri/rip/cd.py:423)

then whipper returns a zero status code. I would expect something that is non zero for further processing within a script.
@thomas-mc-work thomas-mc-work changed the title wrong status when giving up wrong status code when giving up Oct 29, 2016
@JoeLametta JoeLametta added the Bug Generic bug: can be used together with more specific labels label Oct 30, 2016
@JoeLametta
Copy link
Collaborator

Fixed.
Please let me know if now it works as expected.

@JoeLametta JoeLametta reopened this Oct 30, 2016
@JoeLametta JoeLametta added this to the 1.0 milestone Oct 30, 2016
@thomas-mc-work
Copy link
Contributor Author

Yes, it's working 👍

@JoeLametta
Copy link
Collaborator

Yes, it's working 👍

Fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Generic bug: can be used together with more specific labels
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@thomas-mc-work @JoeLametta