Avoid zero padding in logger track numbers #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this issue has been already fixed with commit 4a53ecb as mentioned in #340 (comment) |
|
Sorry, I meant to update the comment for why I made this PR, got distracted, and forgot. I added in a brief sentence to the original message. Both TOC (what you changed) and Tracks (what this changes) used to left pad numbers with that leading zero and both have the same bug of those numbers being treated as octals. 4a53ecb just updated the TOC listing, but didn't touch the Tracks listing. This PR brings them inline with that same fix. |
|
Understood, thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the second dictionary (Tracks) from #340
Commit 4a53ecb fixed this issue within the TOC dictionary, but the issue still remained for the Tracks dictionary.