Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warnings/errors from various static analysis tools #357

Merged
merged 13 commits into from
Feb 2, 2019

Conversation

JoeLametta
Copy link
Collaborator

@JoeLametta JoeLametta commented Jan 17, 2019

Address warnings/errors from various static analysis tools (PyCharm, Pylint, Flake8).

@JoeLametta JoeLametta force-pushed the bugfix/idea-issues branch 8 times, most recently from 3742381 to c8eb145 Compare January 18, 2019 10:05
@JoeLametta JoeLametta changed the title [WIP] Various fixes/improvements WIP: Various fixes/improvements Jan 18, 2019
- Remove redundant escape
- Remove erroneous character
- Remove duplicate character
- Fix PEP8's line too long warning
- Remove useless parentheses
- Use triple quotes for docstring
- Address pylint's 'inconsistent-return-statements'
- Specify string format arguments as logging function parameters
- Comment out already disabled block of code
- Remove useless else (after return)
- Remove useless statement
- Do not import already imported module
- Replace print statement with function call
- Replace except ..., ...: syntax with except ... as ...:
- Simplify obsolete try ... except ... code block
- Replace some unicode calls with u-prefixed strings
- Do not use `len(SEQUENCE)` to determine if a sequence is empty
- Replace dictionary creation
- Drop support for GObject static bindings
Also clarified a statement
@JoeLametta JoeLametta changed the title WIP: Various fixes/improvements Address warnings/errors from various static analysis tools Feb 2, 2019
@JoeLametta JoeLametta merged commit 77679e8 into develop Feb 2, 2019
@JoeLametta JoeLametta deleted the bugfix/idea-issues branch February 2, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants