WIP: Add more metadata options for file templates #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Máximo Castañeda <[email protected]>
%D: release title without disambiguation and other extras %T: medium title, disc number if it doesn't have one %N: medium position in the collection %M: total medium count in the collection Signed-off-by: Máximo Castañeda <[email protected]>
An "output directory is a finished rip" error is raised when a log file is found in the output directory, and that is *any* `.log` file, which may be there from a different rip. Signed-off-by: Máximo Castañeda <[email protected]>
Signed-off-by: Máximo Castañeda <[email protected]>
Signed-off-by: Máximo Castañeda <[email protected]>
JoeLametta
added a commit
that referenced
this pull request
May 16, 2021
This pull request extends the supported template variables. Additions: - `%B`: release barcode (already included but is now allowed) - `%C`: release catalog number (already included but is now allowed) - `%c`: release disambiguation comment - `%D`: disc title without disambiguation - `%I`: MusicBrainz Disc ID - `%M`: total number of discs in the chosen release - `%N`: number of current disc - `%T`: medium title When the relative metadata is available, whipper now adds the `TRACKTOTAL`, `DISCTOTAL` and `DISCNUMBER` metadata tags to the audio tracks. I've also taken the inspiration from pull request #476. Resolves #401, resolves #440, resolves #448.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice this probably shouldn't be merged as is, I've just copied and adapted some other code already in whipper, not really knowing if what I was doing was right. I've not even run the tests, or updated them and the documentation.
The WIP tag means it works for me (a very light user) and someone with real knowledge can take it and do it The Right Way, not that I'm still working on it.
May be of use to #448, #440 and #401. Given that the 'bare' release title is provided through a new variable, it doesn't affect users that like current behaviour. The flac metadata is still in the long format, though. The new ...-mdisc options may be too much, but they also may be useful if you launch whipper from a script and you want different templates for mono- and multi-disc releases.
Feel free to appropriate the good bits, discard the garbage, open a new PR and close this one.