Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardise program/sox.py formatting, add test case, docstring #53

Merged
merged 6 commits into from
Oct 21, 2016
Merged

standardise program/sox.py formatting, add test case, docstring #53

merged 6 commits into from
Oct 21, 2016

Conversation

RecursiveForest
Copy link
Contributor

PEP8y inspired update for sox + a sox.peak_level() test case.

JoeLametta
JoeLametta reviewed Oct 21, 2016
View reviewed changes
Copy link
Collaborator

@JoeLametta JoeLametta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is sox included in the testing dependencies? (isn't it just a "plain" dependency?)

@RecursiveForest
Copy link
Contributor Author

Good point. Reclassified as a normal depencency. Added it to the README as well.

@JoeLametta JoeLametta merged commit 8721ba1 into whipper-team:master Oct 21, 2016
@JoeLametta
Copy link
Collaborator

Merged, thanks.

@RecursiveForest RecursiveForest deleted the sox-improvement branch October 22, 2016 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLametta JoeLametta JoeLametta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RecursiveForest @JoeLametta