Persist False value for defeats_cache correctly #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cdparanoia can't work around the audio caching of a drive, defeats_cache = False is written to the config. However, when it is read back the string 'False' ends up being converted to True (as it is not an empty string). This corrects the behaviour when reading the value back and adds tests to make sure that both True and False can be correctly retrieved from the config.
ribbons
changed the title
|
Good catch!
I think the only thing impacted by this bug (as it looks like a mistake to me) is the status reporting (log and stdout messages). Thanks for the PR. |
|
Great - thanks. Glad it didn't have any effect on completed rips. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
cdparanoiacan't work around the audio caching of a drive,defeats_cache = Falseis written to the config. However, when it is read back the string'False'ends up being converted toTrue(as it is not an empty string).This PR corrects the behaviour when reading the value back and adds tests to make sure that both
TrueandFalsecan be correctly retrieved from the config.What I'm not sure about is the impact of this bug - does the incorrectly retrieved value have an impact on rips completed? I wonder why it didn't get noticed before (unless I'm reading git blame wrong, it looks like it might have been in morituri since Dec 2012) - is it unusual for
cdparanoiato be unable to work around the audio caching behaviour of a drive?