Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test keys and refactor key state function #266

Merged
merged 3 commits into from
Nov 23, 2017
Merged

Conversation

dethos
Copy link
Collaborator

@dethos dethos commented Nov 22, 2017

The valid key used in the test suit wasn't fit for this case (since it expired recently). This key was replaced with a new one.

Also updated python-gnupg package and re-factored the key_sate check, since it was cause some issues with revoked keys.

@dethos dethos changed the title Test Keys WIP: Test Keys Nov 22, 2017
@dethos dethos changed the title WIP: Test Keys WIP: Test Keys and key check refactor Nov 22, 2017
@dethos dethos changed the title WIP: Test Keys and key check refactor Change test keys and refactor key state function Nov 23, 2017
humans/utils.py Outdated
state = "valid"
result = results[-1]
# Since the keyring is exlusive for this import.
# Only the imported ket exists in it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dethos Small typo

Copy link
Collaborator

@jlbribeiro jlbribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging 👍

@jlbribeiro jlbribeiro merged commit 305e0af into master Nov 23, 2017
@jlbribeiro jlbribeiro deleted the update_tests branch November 23, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants