Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Writes #7

Closed
Stebalien opened this issue Jul 30, 2017 · 2 comments
Closed

Partial Writes #7

Stebalien opened this issue Jul 30, 2017 · 2 comments
Labels
P0 Critical: Tackled by core team ASAP

Comments

@Stebalien
Copy link
Member

So, I'm a bit worried we can write a partial message if a deadline is reached while writing. This would put the connection into an unusable state.
@Stebalien
Copy link
Member Author

I can confirm that this is a problem. Luckily, we don't do this 😉 at the moment.

@Stebalien Stebalien mentioned this issue Sep 19, 2017
Closed
@Stebalien
Copy link
Member Author

(we do actually do this... we should fix this)

@whyrusleeping whyrusleeping added the P0 Critical: Tackled by core team ASAP label Oct 17, 2017
@whyrusleeping whyrusleeping mentioned this issue Oct 17, 2017
Closed
18 tasks
@whyrusleeping whyrusleeping added the status/ready Ready to be worked label Oct 17, 2017
Stebalien added a commit that referenced this issue Sep 14, 2018
@Stebalien
close the connection on partial writes
fd3b3b3 
fixes #7 (not the best way but it works)
@Stebalien Stebalien mentioned this issue Sep 14, 2018
Merged
@ghost ghost removed the status/ready Ready to be worked label Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @whyrusleeping