Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the logic for updating IsEmpty #324

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

BAndysc
Copy link
Contributor

@BAndysc BAndysc commented Mar 8, 2024

Unifies the logic for managing the VisibleDockables. The previous code was error prone and in fact there was one typo which caused dockables to randomly disappear (#323). Additionally, the IsEmpty should be also set if there are dockables in the VisibleDockables list, but they are empty. This can happen if all dockables are pinned

Before the fix:

Screen.Recording.2024-03-08.at.02.14.25.mov

After the fix:

Screen.Recording.2024-03-08.at.02.14.46.mov

Before the fix:

Screen.Recording.2024-03-08.at.02.50.21.mov

After the fix (with #322):

Screen.Recording.2024-03-08.at.02.51.48.mov

Fixes: #301, #278, #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window disappears after dragging and dropping
2 participants