Border issue #343 #352
Merged
Border issue #343 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulation Adds the unit tests to check whether children has proper dimensions
|
The solution I wrote about in the issue is wrong, sometimes fractions can add up to more than one pixel. New solution adds fractions to a point where a whole pixel can be added to the width/height of the child control. It assumes that parent height/width is a whole number, so it does not check if there is a remaining fraction at the end of the loop. |
OlivierMiracle
commented
Aug 15, 2024
wieslawsoltes
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix of #343 , caused by multiplying by proportion variable and supposedly wrong rounding.
It adds private method to properly calculate the dimension of children and unit tests to check whether the sum of the children adds up to the dimensions of the parent.
Fixes #343