Skip to content
This repository has been archived by the owner on May 22, 2022. It is now read-only.

msa.js doesn't work with Firefox Nightly 85 #257

Closed
MrTomRod opened this issue Dec 10, 2020 · 7 comments
Closed

msa.js doesn't work with Firefox Nightly 85 #257

MrTomRod opened this issue Dec 10, 2020 · 7 comments

Comments

@MrTomRod
Copy link

MrTomRod commented Dec 10, 2020

Thanks for your great work!

Using Firefox Nightly 85.0a1 (2020-12-09) on http://msa.biojs.net/ I get the following error in my console:

Uncaught TypeError: t.on is not a function
    resetSeqs index.js:58
    e index.js:56
    resetSeqs index.js:59
    t index.js:14
    _loadSeqs msa.js:121
    initialize msa.js:79
    Backbone 3
    <anonymous> norowuvoqo.js:18
index.js:58:9
    resetSeqs index.js:58
    e index.js:56
    resetSeqs index.js:59
    t index.js:14
    _loadSeqs msa.js:121
    initialize msa.js:79
    Backbone 3
    <anonymous> norowuvoqo.js:18

Maybe it's just the a nightly bug, but it could be worth looking into this error before Firefox 85 becomes mainline.

@MrTomRod
Copy link
Author

MrTomRod commented Jan 5, 2021

Problem still exists in Firefox 85 and is also present in Firefox 86.

Firefox 85 will be released very soon! (2021-01-26)

Please fix this bug soon, I rely on it!

@MrTomRod
Copy link
Author

Still broken on Firefox 90.0 (64-Bit)...

@MrTomRod
Copy link
Author

Found a dirty workaround: Simply remove this from msa.js:

t.on("add change reset ",e,this),e.call(this)

alt text

fredericlemoine added a commit to C3BI-pasteur-fr/ngphylogeny-django that referenced this issue Jul 27, 2021
bvaisvil pushed a commit to bvaisvil/react-msa-viewer that referenced this issue Aug 10, 2021
It isn't clear what was intended with this line but the MSA appears to function without it.
bvaisvil pushed a commit to bvaisvil/react-msa-viewer that referenced this issue Aug 10, 2021
The source of the issue is that the behavior of the "in" operator on an Array changed between firefox and chrome versions.

`"at" in []` returned `false`, now it returns `true` this is because `at` is now a method of `Array`.
adf-ncgr added a commit to legumeinfo/stat.seqs that referenced this issue Aug 26, 2021
…/msa#257 but I think they mistook where the issue was coming from
adf-ncgr added a commit to legumeinfo/msa that referenced this issue Aug 26, 2021
@guignonv
Copy link

If I may, I think the correct fix is not to comment "t.on("add change reset ",e,this),e.call(this)" but rather turn the "at" into an "on" a few characters before:
if(this.seqs=[],!t instanceof Array||"on"in t) (instead of if(this.seqs=[],!t instanceof Array||"at"in t)).
;-)

@MrTomRod
Copy link
Author

MrTomRod commented Sep 10, 2021

Wow, how the hell did you divine this? 🤣 Thanks.

MrTomRod pushed a commit to opengenomebrowser/opengenomebrowser that referenced this issue Sep 10, 2021
- update msa.js and add improved fix (wilzbach/msa#257)
@slimsuite
Copy link

Hi, I've also been having problems that alignments have stopped displaying. Does the above fix mean that the tool will become available again soon? It's really useful! (Well done, and thanks!) (I am using it with <script src="https://cdn.bio.sh/msa/latest/msa.min.gz.js"></script>)

@MrTomRod
Copy link
Author

MrTomRod commented Sep 13, 2021

I would not count on it - the developer has moved on to other things. Just host an edited version of msa.js yourself. (If you can't, and you trust me, and need a short-term solution, you can use this: <script src="https://opengenomebrowser.bioinformatics.unibe.ch/static/align/js/msa.min.js"></script>)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants