Legend bar #10
Open
Legend bar #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added this 'hack' to the render part of the widget to play around with it. Maybe we should make it a real entityl |
|
Nice job! The top legend looks good! It might make sense to turn this thing into it's own control/render class since it is pretty different than the normal plot. I would suggest to go "scope style" and change the Y axis into units / div and have the handle draw a zero line. |
windelbouwman
force-pushed
the
master
branch
5 times, most recently
from
9d0c231
to
63233b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what to name it yet though, but I have moved the legend attached to the cursor to a legend / signal bar at the top. In this bar, the signals can be selected as well. Maybe with multiple clicks or something, we could cycle through the functionality of the bar. This could include the signal names, the value at the cursor position etc.