Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable wine flatpak #7

Open
merged 1,724 commits into
base: master
Choose a base branch
from
Jan 18, 2018
Open

Stable wine flatpak #7

merged 1,724 commits into from
Jan 18, 2018

Conversation

Lvaskz
Copy link

@Lvaskz Lvaskz commented Sep 3, 2017

Hi, I do not know if this is possible from here, but here I go. Can you build wine like an appimage, or maybe flatpak the snap? I have tried the appimage and I have not seen anything simpler to distribute software in linux. No terminal, no breaking the system, etc, etc. etc. Do you have any plans for these new packages?

@Lvaskz Lvaskz changed the title Stable wine Stable wine flatpak Sep 20, 2017
PiotrCW and others added 29 commits December 18, 2017 12:35
@PiotrCW @julliard
msvcr71: Don't raise exception in _invalid_parameter.
8ee96fe 
Support for invalid parameter handler was added in msvcr80.

Signed-off-by: Piotr Caban <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@PiotrCW @julliard
msvcrt: Correctly set rounding mode in _ftol implementation.
22edbd8 
Signed-off-by: Piotr Caban <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
webservices/tests: Merge the listener tests into channel.c.
209ad4c 
Signed-off-by: Hans Leidekker <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
webservices/tests: Register an exception with the firewall to avoid a…
1ca988d 
… dialog.

Signed-off-by: Hans Leidekker <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@zzhiyi @julliard
winecfg: Fix a crash when inputting non-ASCII dll override name.
eee8131 
Signed-off-by: Zhiyi Zhang <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@PietJankbal @julliard
kernelbase: Quiet a noisy fixme in QuirkIsEnabled3.
54c414d 
Signed-off-by: Louis Lenders <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@slackner @julliard
user32: Globally invalidate key state on changes in other threads.
059d5ec 
Signed-off-by: Alexandre Julliard <[email protected]>
@cjacek @julliard
mshtml.idl: Added IDOMMouseEvent declaration.
d943a5c 
Signed-off-by: Jacek Caban <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@cjacek @julliard
mshtml.idl: Added events dispinterfaces declarations.
eb2bf1d 
Signed-off-by: Jacek Caban <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
msvcp90/tests: Use the correct return type for basic_istream::ipfx.
fc69b10 
Signed-off-by: Piotr Caban <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@MingcongBai @julliard
po: Update Simplified Chinese translation.
7183dc7 
Signed-off-by: Mingcong Bai <[email protected]>
Signed-off-by: Jactry Zeng <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
kernel32/tests: Improve tests for 32/64-bit image mappings.
e5d8129 
Signed-off-by: Alexandre Julliard <[email protected]>
@alexhenrie @julliard
gdi32: Scale outline font metrics as signed integers.
d819609 
Signed-off-by: Alex Henrie <[email protected]>
Signed-off-by: Huw Davies <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@hdmdavies @julliard
gdi32: Set otmMacLineGap from the line gap in the hhea table.
ccc871d 
Signed-off-by: Huw Davies <[email protected]>
Signed-off-by: Alex Henrie <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
comctl32/tests: Add ListBox tests.
b073396 
Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
comctl32/tests: Remove some workarounds that no longer apply.
8a93b18 
Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
bcrypt: Fix build on macOS 10.8 and older.
dda6703 
Based on a patch by Ryan Schmidt.

Signed-off-by: Hans Leidekker <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
bcrypt: Require macOS version 10.7 or newer for encryption support.
68cff26 
Reported by Ryan Schmidt.

Signed-off-by: Hans Leidekker <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@alexhenrie @julliard
mmdevapi/tests: Fix memory leaks (Coverity).
10aa228 
Signed-off-by: Alex Henrie <[email protected]>
Signed-off-by: Andrew Eikum <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
comctl32/tooltips: Remove window subclass right before window is dest…
b68dbf4 
…royed.

Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@kimmalmo @julliard
po: Update Norwegian translation.
0ec9eca 
Signed-off-by: Kim Malmo <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@zfigura @julliard
user32/tests: Don't leave hwndMain in a topmost state.
51f555a 
Signed-off-by: Zebediah Figura <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@zfigura @julliard
user32/tests: Add more tests for SetActiveWindow().
e188d66 
Signed-off-by: Zebediah Figura <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@zfigura @julliard
user32/tests: Add activation tests for hiding windows.
2f0d573 
Signed-off-by: Zebediah Figura <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@zfigura @julliard
user32/tests: Add activation tests for minimizing windows.
83c806e 
Signed-off-by: Zebediah Figura <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@zfigura @julliard
winegstreamer: Hold a reference to the filter in push_data().
079d63e 
Signed-off-by: Zebediah Figura <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@cjacek @julliard
jscript: Use WARN for exception traces instead of separated debug cha…
77e2744 
…nnel.

Signed-off-by: Jacek Caban <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
include: Add newer definitions for user controls.
6fb250e 
Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
mfplat: Implement MFGetService().
42b04e2 
Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
jozefkucia and others added 13 commits January 11, 2018 22:30
@jozefkucia @julliard
ddraw/tests: Avoid touching unsupported clip planes.
9525f3a 
Signed-off-by: Józef Kucia <[email protected]>
Signed-off-by: Henri Verbeet <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@jozefkucia @julliard
ddraw/tests: Fully initialize surface desc in surface enumeration tests.
d146940 
Signed-off-by: Józef Kucia <[email protected]>
Signed-off-by: Henri Verbeet <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@jozefkucia @julliard
ddraw/tests: Rewrite LimitTest().
4767991 
Signed-off-by: Józef Kucia <[email protected]>
Signed-off-by: Henri Verbeet <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@jozefkucia @julliard
ddraw/tests: Rewrite SetRenderState() tests.
110eecf 
Signed-off-by: Józef Kucia <[email protected]>
Signed-off-by: Henri Verbeet <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
msxml3/tests: Use temporary user directory for test files.
cefe6e8 
Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
user32/tests: Add EM_GETLINE test.
8d8c94d 
Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@nsivov @julliard
comctl32/tests: Add EM_GETLINE test.
258dc94 
Signed-off-by: Nikolay Sivov <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@alexhenrie @julliard
shell32/tests: Drop shell folder test dynamic imports for Windows <= …
dca38ea 
…2000.

Signed-off-by: Alex Henrie <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@alexhenrie @julliard
shell32/tests: Drop shell folder test workarounds for Windows <= 2000.
332898e 
Signed-off-by: Alex Henrie <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
Release 3.0-rc6.
320152b 
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
ntdll: Avoid the strd ARM instruction.
3e26caf 
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
po: Update German translation.
43c7475 
Signed-off-by: Julian Rüger <[email protected]>
Signed-off-by: Alexandre Julliard <[email protected]>
@julliard
Release 3.0.
f6b5a7c 
Signed-off-by: Alexandre Julliard <[email protected]>
@hubot hubot merged commit f6b5a7c into master Jan 18, 2018
kakra pushed a commit to kakra/wine that referenced this pull request Aug 24, 2018
@zfigura @kakra
ntdll: Correctly allocate the esync handle cache.
9491a58 
Fixes a regression introduced by 7b583a3.

Should hopefully fix wine-mirror#7.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 1, 2018
@zfigura @kakra
ntdll: Correctly allocate the esync handle cache.
f8bc405 
Fixes a regression introduced by 7b583a3.

Should hopefully fix wine-mirror#7.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 18, 2018
@zfigura @kakra
ntdll: Correctly allocate the esync handle cache.
9a5b23c 
Fixes a regression introduced by 7b583a3.

Should hopefully fix wine-mirror#7.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 23, 2018
@zfigura @kakra
ntdll: Correctly allocate the esync handle cache.
a6110fd 
Fixes a regression introduced by 7b583a3.

Should hopefully fix wine-mirror#7.
kakra pushed a commit to kakra/wine that referenced this pull request Dec 14, 2018
@zfigura @kakra
ntdll: Correctly allocate the esync handle cache.
17bd1f0 
Fixes a regression introduced by 7b583a3.

Should hopefully fix wine-mirror#7.
neurotensin added a commit to neurotensin/wine-patched that referenced this pull request Jul 18, 2019
@neurotensin
changed assert (arg < sym->argc); to if assert (arg < sym->argc) retu…
d3bb899 
…rn NULL, to allow program to finish

have a DLL that only gets partially processed, and has the following stack:
winedump: symbol.c:184: symbol_get_spec_type: Assertion `0' failed.

Program received signal SIGABRT, Aborted.
0xf7fd4dc9 in __kernel_vsyscall ()
(gdb) where
#0  0xf7fd4dc9 in __kernel_vsyscall ()
wine-staging#1  0xf7ddf832 in raise () from /lib/i386-linux-gnu/libc.so.6
wine-staging#2  0xf7de0cc1 in abort () from /lib/i386-linux-gnu/libc.so.6
wine-mirror#3  0xf7dd77bb in ?? () from /lib/i386-linux-gnu/libc.so.6
wine-mirror#4  0xf7dd7819 in __assert_fail () from /lib/i386-linux-gnu/libc.so.6
wine-mirror#5  0x5656ff9a in symbol_get_spec_type (sym=0xffffd05c, arg=1) at symbol.c:184
wine-mirror#6  0x565661b5 in output_spec_symbol (sym=0xffffd05c) at output.c:107
wine-mirror#7  0x56556d25 in main ()
Guy1524 referenced this pull request in Guy1524/wine Dec 6, 2019
@zfigura @Guy1524
ntdll: Correctly allocate the esync handle cache.
3f0964b 
Fixes a regression introduced by 7b583a3.

Should hopefully fix #7.
Guy1524 referenced this pull request in Guy1524/wine Jan 17, 2020
@zfigura @Guy1524
ntdll: Correctly allocate the esync handle cache.
7fc0837 
Fixes a regression introduced by 7b583a3.

Should hopefully fix #7.
Guy1524 referenced this pull request in Guy1524/wine Jul 13, 2020
@zfigura @Guy1524
ntdll: Correctly allocate the esync handle cache.
49ffbbe 
Fixes a regression introduced by 7b583a3.

Should hopefully fix #7.
@donno2048
Copy link

Please add a label and remove it to allow this PR to close
image

jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 11, 2024
@bernhardu @jeremyd2019
ws2_32: Disable check for local socket handles.
d1e5a96 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 12, 2024
@bernhardu @jhol
ws2_32: Disable check for local socket handles.
f9dce25 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 15, 2024
@bernhardu @jeremyd2019
ws2_32: Disable check for local socket handles.
8c7be8a 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 17, 2024
@bernhardu @jeremyd2019
ws2_32: Disable check for local socket handles.
d09dc5c 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
@Neustradamus
Copy link

Dear @wine-mirror team,

I would like to know who manage this organization and this repository.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.