fix: Failed image message are not visible on chat #WPB-11035

[m-zagorski]

WPB-11035 [Android] No error displayed when sending imaged or gifs without internet being availble

https://wearezeta.atlassian.net/browse/WPB-11035

What's new in this PR?

Issues

When sending image message fails, it was not visible in chat at all, so we have seen on conversation screen that we sent image, but it was not there.

Solutions

While checking for missing image data from remote, we can also check if its our own message, it it is - its safe to display it in chat

Dependencies (Optional)

We also need this change for full experience: wireapp/kalium#3063

Needs releases with:

• Update status after reuploading

Testing

How to Test

• Turn off internet
• Send image
• Image is present in chat with retry options

Attachments (Optional)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https:/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.31%. Comparing base (2c80996) to head (0d1ef27).

Files with missing lines	Patch %	Lines
...wire/android/mapper/RegularMessageContentMapper.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3516      +/-   ##
=====================================================
- Coverage              45.32%   45.31%   -0.01%     
=====================================================
  Files                    470      470              
  Lines                  15692    15692              
  Branches                2626     2626              
=====================================================
- Hits                    7112     7111       -1     
  Misses                  7836     7836              
- Partials                 744      745       +1     

Files with missing lines	Coverage Δ
...wire/android/mapper/RegularMessageContentMapper.kt	18.95% <50.00%> (-0.66%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c80996...0d1ef27. Read the comment docs.

[github-actions]

Built wire-android-staging-compat-pr-3516.apk is available for download

[github-actions]

Built wire-android-dev-debug-pr-3516.apk is available for download

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud