fix: resolve content layer images without filePath set #11858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0508bcb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
reviewed
Aug 28, 2024
| entry.data = updateImageReferencesInData(entry.data, entry.filePath, imageAssetMap); | ||
| } | ||
| // @ts-expect-error virtual module | ||
| const { default: imageAssetMap } = await import('astro:asset-imports'); |
There was a problem hiding this comment.
If you want you can type this in dev-only.d.ts that's at the root of the package
There was a problem hiding this comment.
I'm not sure why, but those types don't seem to be picked up in this file
matthewp
approved these changes
Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Correctly handles images in entries without filePaths. Also improves error handling for invalid images.
Testing
Adds tests
Docs