Document harvesting better #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added explanation and information for newbies
|
I have read the CLA Document and I hereby sign the CLA |
robmen
requested changes
Oct 31, 2023
| ```xml | ||
| <Project Sdk="WixToolset.Sdk/4.0.2" TreatWarningsAsErrors="true"> | ||
| <ItemGroup> | ||
| <HarvestDirectory Include="$(SolutionDir)MyProject\bin\Release\net7.0"> |
There was a problem hiding this comment.
$(SolutionDir) should not be used in examples. It is not always available.
| @@ -34,15 +56,15 @@ The following properties control harvesting: | |||
| | -------- | ----------- | | |||
| | `HarvestDirectoryAutogenerateGuids` | Optional boolean property. Whether to generate authoring that relies on auto-generation of component GUIDs. The default is `$(HarvestAutogenerateGuids)` if specified; otherwise, **true**. | | |||
| | `HarvestDirectoryComponentGroupName` | Optional string property. When harvesting multiple directories in a project, specify this metadata to create unique file names for the generated authoring. The component group name that will contain all generated authoring. | | |||
| | `HarvestDirectoryDirectoryRefId` | Optional string property. The identifier of the Directory element that will contain all generated authoring. | | |||
| | `HarvestDirectoryDirectoryRefId` | Optional string property. The identifier of the Directory into which the harvested files will be copied when you run the installer. | | |||
There was a problem hiding this comment.
be copied when you run the installer. should be replaced with simply installed.
There was a problem hiding this comment.
I'm writing this with newbies in mind. I really struggled with the documentation and I'm suggesting changes that make it more understandable. Verbose and explicit was what I was aiming for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explanation and information for newbies