Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW please] CreateGroups additions #530

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bevanweiss
Copy link
Contributor

@bevanweiss bevanweiss commented Jun 19, 2024

Just a placeholder for the current state of development on the ability to add Groups. wixtoolset/issues#8577

Not sure if it works yet, splitting out the tables cost me a little more time than I anticipated, and I'm unsure that the decompile is right.

I'll build out a few more of the build test cases, to validate the expected preconditions etc (i.e. marking CreateGroup when it's not under a component, and similar).

Please raise any style / formatting issues, that way I've got the most time to address them :)

I've just noticed I've missed a couple of Wix4-.Wix6 references (around CustomAction names). I'll tidy these up tomorrow.

Closes wixtoolset/issues#8577

@bevanweiss bevanweiss force-pushed the util_creategroup branch 8 times, most recently from 871c524 to 06e7fa6 Compare June 28, 2024 14:40
@bevanweiss bevanweiss force-pushed the util_creategroup branch 3 times, most recently from 15346cb to fc0bf93 Compare July 6, 2024 12:44
@bevanweiss
Copy link
Contributor Author

@barnson Are there any additional integration tests that you think would be good to have beyond what I've already got in this?
There's a small set that I haven't yet put in that would be around the domain functionality (similar to the new user one I've added on the other PR #547), I think that would be:

  1. Creating/removing a domain group
  2. Adding/removing a domain user from a domain group
  3. Adding/removing a domain group from a domain group
  4. Adding/removing a domain user from a local group
  5. Adding/removing a domain group from a local group

I know there's a heap of code in this PR, however there's not really many easily separable portions that would be meaningful on their own. However, let me know if there's any way you can see that I could split it into more easily reviewable/pull-able portions.

@barnson
Copy link
Member

barnson commented Jul 15, 2024

I'm not a domain expert but the tests look reasonable to me.

@bevanweiss bevanweiss marked this pull request as draft July 15, 2024 09:50
Signed-off-by: Bevan Weiss <[email protected]>
Local group membership Add/Remove working, however with
BUILTIN local system groups .NET doesn't appear to locate them as either
groups nor basic security Principals.  Still needs work to fix the test
for nested groups.  Ideally with some way to test for domain groups.


Signed-off-by: Bevan Weiss <[email protected]>
Signed-off-by: Bevan Weiss <[email protected]>
Fixups to a few test cases.

Signed-off-by: Bevan Weiss <[email protected]>
@bevanweiss bevanweiss changed the title [DRAFT] CreateGroups additions [REVIEW please] CreateGroups additions Aug 4, 2024
@bevanweiss bevanweiss marked this pull request as ready for review August 4, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIP: User Group creation / removal and Group->Group membership creation
2 participants