Replace Travis with GitHub Actions #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking #368 |
dhermes
changed the title
stsewd
reviewed
Dec 17, 2020
There was a problem hiding this comment.
Thanks this looks good! We should include python 3.9 as well and remove 3.5.
https:/theacodes/nox/blob/4e1842246d8b005e0dadf4b0f3e9d1123cefa651/setup.py#L37-L41
I think is fine to keep using appveyor for windows.
stsewd
approved these changes
Dec 28, 2020
There was a problem hiding this comment.
LGTM, thanks! I'll leave to @theacodes to merge this, since she needs to set the PYPI_API_TOKEN.
|
The secret's been added. @stsewd I'm also happy to grant you PyPI permissions. Feel free to merge once the suggestion is accepted. |
|
@theacodes thanks! I already have permission on pypi, just wasn't able to create secrets in the repo |
Setup a Github Action configuration file that runs the same steps as the Travis setup, i.e, building, testing, linting and building documentation for Ubuntu and MacOS systems for each Python version between 3.5 and 3.7. It uses [miniconda action](https:/marketplace/actions/setup-miniconda) to install and configure miniconda, and [PyPI publish](https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/) action to deploy the package to PyPI.
|
Superseded by #389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Now that Github introduced actions we could replace
.travis.ymlconfiguration, having a more integrated workflow for the testing and deployment pipelines.I created this PR that includes a GH action that does the same steps as Travis: building the package for a matrix of different systems (ubuntu and macos for each Python version between 3.5 and 3.6), configuring and installing Miniconda, deploying to PyPI on tags, linting the code and building the docs.
You can see an example of this actions running on my fork, here:
https:/ajcerejeira/nox/actions/runs/265352396
I tried to make the pipeline also work for windows, but I was not able to run the tests (building and installing the packages worked fine), perhaps I should look into the
appveyor.ymlfile and try to replicate that?If this PR is accepted the repository owner should add
PYPI_PASSWORDto this repository secret settings, like explained here:https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
Thank you all, and have a nice day :)
Close #368