Refactoring the backup deletion process to cleanup backup info on master host. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpbackup save information in $MASTER_DATA_DIRECTORY/backups. When deleting a backup using a plugin, it is necessary to clear local backup information on the master. Added deletion of files on the master when deleting a backup using a plugin. Also, performed a small refactoring with the addition of handlers for error handling. There may be cases when a backup hangs in the "In Progress" status. Additionally, backups in the "Failure" status save information about themselves. You can get a report for them, and they also need to be deleted. The conditions in the checkBackupCanBeUsed() function have been changed. The conditions in checkBackupCanBeUsed() function have been changed to work with backups that have not been deleted. This allows for the deletion of backups in "Failure" or "In Progress" statuses.
Remove --deleted flag. Only deleted backups are deleted. In order to delete information about backup from the database, it must have the deleted status.
E2e tests tests will be refactored in the future.
woblerr
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpbackup save information in
$MASTER_DATA_DIRECTORY/backups. It is necessary to clear backup information on the master.Added deletion of files on the master when deleting a backup using a plugin. Also, performed a small refactoring with the addition of handlers for error handling.
There may be cases when a backup hangs in the
In Progressstatus. Additionally, backups in theFailurestatus save information about themselves. You can get a report for them, and they also need to be deleted.The conditions in
checkBackupCanBeUsed()function have been changed to work with backups that have not been deleted. This allows for the deletion of backups inFailureorIn Progressstatuses.The
--deletedflag was removed forhistory-cleancommand.Only deleted backups are deleted. In order to delete information about backup from the database, it must have the deleted status.
The tests have been updated for these changes.