Update 08-publish.js to ensure publish modules are public. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to update the documentation on item 8. Currently it references using 'npm publish'. Early in the exercise we create a scoped package. By default when a scoped package is published it is private. This requires a paid account. I assume it is best the ensure a person's first publish be public because it is unlikely they have a paid account. I think we could just inform the user of the '--access=public' flag and avoid the situation. Below is the npm documentation on this subject.
https://docs.npmjs.com/getting-started/scoped-packages#publishing-a-scoped-package