Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully JSON based map configuration #41

Closed
sheppard opened this issue May 5, 2015 · 1 comment
Closed

fully JSON based map configuration #41

sheppard opened this issue May 5, 2015 · 1 comment
Labels
enhancement needs concept design
Milestone
0.8.1

Comments

@sheppard
Copy link
Member

sheppard commented May 5, 2015

Like #38, but for wq/map.js. This would allow changing at least basemaps and GeoJSON layers via only map config.

This might prove difficult for things like map.config.maps[page].onshow and layerConf.oneach, which are best implemented as JS functions. I guess there's always eval()...
@sheppard sheppard modified the milestone: 1.0 May 6, 2015
sheppard added a commit that referenced this issue Jul 9, 2015
@sheppard
make basemaps json-configurable (see #41)
d3cbd74
sheppard added a commit that referenced this issue Jul 23, 2015
@sheppard
map plugin improvements
ee3dda9 
 - set "this" to plugin when calling functions
 - separate popup and oneach options; make icon template-capable (see #41)
 - ensure serialized JSON is updated after delete
@sheppard sheppard modified the milestones: 0.8.1, 1.0 Aug 18, 2015
@sheppard
Copy link
Member Author

This is much better now thanks to ee3dda9 - no eval(), but the most common use case for oneach (map popups) is now a separate option. onshow will still require actual JS.

sheppard added a commit that referenced this issue Sep 17, 2015
@sheppard
json-configurable cluster icon (see #41)
7735432
sheppard added a commit that referenced this issue Jul 14, 2017
@sheppard
remove onshow in favor of wq/app plugin (see #41)
d5f47f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs concept design
Projects
None yet
Milestone
0.8.1
Development

No branches or pull requests
1 participant
@sheppard