Skip to content
This repository has been archived by the owner on Dec 24, 2023. It is now read-only.

Make image comparison function support Node 18 #116

Closed
mhdSid opened this issue Sep 20, 2022 · 1 comment · Fixed by #121
Closed

Make image comparison function support Node 18 #116

mhdSid opened this issue Sep 20, 2022 · 1 comment · Fixed by #121

Comments

@mhdSid
Copy link

mhdSid commented Sep 20, 2022

Is your feature request related to a problem? Please describe.
"resemblejs" has a dependency on "canvas" library which doesn't support NodeJs v.18, therefore, I would like to request that "webdriver-image-comparison" to support NodeJs v.18

Describe the solution you'd like
Use pixelmatch

Describe alternatives you've considered
Create pre-builds for Node 18 within "canvas" library; there is one open issue for this.

Additional context

@mhdSid mhdSid changed the title Make image comparison function supports Node 18 Make image comparison function support Node 18 Sep 20, 2022
@wswebcreation
Copy link
Owner

Hi @mhdSid

Tnx for this issue. I'll release a new version soon with support for Nodejs 18.

For now I want to stick to canvas because it's a bit more flexible but I do like the alternatives. Something to investigate, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants