Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to master #1711

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e7bf593
Bump net.logstash.logback:logstash-logback-encoder from 7.4 to 8.0
dependabot[bot] Jul 29, 2024
0cda02d
Fix #1656: Set develop version to 1.9.0-SNAPSHOT
banterCZ Jul 29, 2024
6e46de9
Merge pull request #1667 from wultra/issues/1656-version-1.9.0-SNAPSHOT
banterCZ Jul 29, 2024
a36adc5
Fix #1668: Add configuration to disable websockets (#1669)
romanstrobl Jul 31, 2024
bbaddc7
Fix #1683: Provide default lang.json for external resources (#1684)
romanstrobl Aug 6, 2024
6cbf405
Fix #1687: Error java.net.MalformedURLException: unknown protocol: cl…
romanstrobl Aug 8, 2024
77bbe49
Merge pull request #1663 from wultra/dependabot/maven/net.logstash.lo…
dependabot[bot] Aug 20, 2024
2c9c214
Bump org.passay:passay from 1.6.4 to 1.6.5
dependabot[bot] Aug 26, 2024
5f1132d
Bump org.springframework.boot:spring-boot-starter-parent
dependabot[bot] Aug 26, 2024
f7105fb
Bump io.swagger.core.v3:swagger-annotations-jakarta
dependabot[bot] Sep 2, 2024
ed98538
Merge pull request #1697 from wultra/dependabot/maven/io.swagger.core…
dependabot[bot] Sep 2, 2024
e29c4d0
Merge pull request #1695 from wultra/dependabot/maven/org.springframe…
dependabot[bot] Sep 2, 2024
c8eef16
Merge pull request #1694 from wultra/dependabot/maven/org.passay-pass…
dependabot[bot] Sep 2, 2024
a6468bc
Bump com.github.eirslett:frontend-maven-plugin from 1.15.0 to 1.15.1
dependabot[bot] Sep 23, 2024
2dda5d5
Bump org.springframework.boot:spring-boot-starter-parent
dependabot[bot] Sep 23, 2024
d6952d9
Merge pull request #1702 from wultra/dependabot/maven/org.springframe…
dependabot[bot] Sep 23, 2024
bec7238
Merge pull request #1701 from wultra/dependabot/maven/com.github.eirs…
dependabot[bot] Sep 23, 2024
1ed4be0
Bump de.skuzzle.enforcer:restrict-imports-enforcer-rule
dependabot[bot] Sep 30, 2024
d0c2172
Bump io.swagger.core.v3:swagger-annotations-jakarta
dependabot[bot] Sep 30, 2024
c1c977b
Merge pull request #1704 from wultra/dependabot/maven/io.swagger.core…
dependabot[bot] Sep 30, 2024
cf05d36
Merge pull request #1703 from wultra/dependabot/maven/de.skuzzle.enfo…
dependabot[bot] Sep 30, 2024
ae1b51f
Add migration instructions from 1.8.x to 1.9.x
banterCZ Oct 2, 2024
99d9f3c
Merge pull request #1707 from wultra/issues/migration-instructions
banterCZ Oct 2, 2024
235972a
Bump wultra-core.version from 1.11.0-SNAPSHOT to 1.11.0
dependabot[bot] Oct 7, 2024
b7666c6
Bump io.swagger.core.v3:swagger-annotations-jakarta
dependabot[bot] Oct 7, 2024
2199f5f
Merge pull request #1708 from wultra/dependabot/maven/wultra-core.ver…
dependabot[bot] Oct 7, 2024
706c0e7
Merge pull request #1709 from wultra/dependabot/maven/io.swagger.core…
dependabot[bot] Oct 7, 2024
06a54a6
Bump io.getlime.security:powerauth-java-crypto
dependabot[bot] Oct 14, 2024
7fba1fb
Merge pull request #1716 from wultra/dependabot/maven/io.getlime.secu…
dependabot[bot] Oct 14, 2024
558f13f
Fix #1717: Add support for bcrypt to store the password (#1718)
romanstrobl Oct 18, 2024
f629fdf
Bump org.passay:passay from 1.6.5 to 1.6.6
dependabot[bot] Oct 21, 2024
a93ffc7
Merge pull request #1719 from wultra/dependabot/maven/org.passay-pass…
dependabot[bot] Oct 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/Migration-Instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

This page contains PowerAuth Web Flow migration instructions.

- [PowerAuth Web Flow 1.9.0](./Web-Flow-1.9.0.md)
- [PowerAuth Web Flow 1.8.0](./Web-Flow-1.8.0.md)
- [PowerAuth Web Flow 1.7.0](./Web-Flow-1.7.0.md)
- [PowerAuth Web Flow 1.6.0](./Web-Flow-1.6.0.md)
Expand Down
5 changes: 5 additions & 0 deletions docs/Web-Flow-1.9.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Migration from 1.8.0 to 1.9.0

This guide contains instructions for migration from PowerAuth WebFlow version `1.8.x` to version `1.9.0`.

There are no database changes needed for this version.
20 changes: 10 additions & 10 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@

<groupId>io.getlime.security</groupId>
<artifactId>powerauth-webflow-parent</artifactId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
<packaging>pom</packaging>

<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.3.2</version>
<version>3.3.4</version>
<relativePath/> <!-- lookup parent from repository -->
</parent>

Expand Down Expand Up @@ -93,21 +93,21 @@
<maven.compiler.target>17</maven.compiler.target>
<bcprov-jdk18on.version>1.78.1</bcprov-jdk18on.version>
<zxing.version>3.5.3</zxing.version>
<passay.version>1.6.4</passay.version>
<passay.version>1.6.6</passay.version>

<!-- Documentation Dependencies -->
<springdoc-openapi-starter-webmvc-ui.version>2.6.0</springdoc-openapi-starter-webmvc-ui.version>
<swagger-annotations-jakarta.version>2.2.22</swagger-annotations-jakarta.version>
<swagger-annotations-jakarta.version>2.2.25</swagger-annotations-jakarta.version>

<moneta.version>1.4.4</moneta.version>
<owasp-java-html-sanitizer.version>20240325.1</owasp-java-html-sanitizer.version>
<logstash.version>7.4</logstash.version>
<logstash.version>8.0</logstash.version>

<!-- Wultra dependencies -->
<wultra-core.version>1.10.0</wultra-core.version>
<powerauth.version>1.8.0</powerauth.version>
<powerauth-crypto.version>1.8.0</powerauth-crypto.version>
<powerauth-push.version>1.8.0</powerauth-push.version>
<wultra-core.version>1.11.0</wultra-core.version>
<powerauth.version>1.9.0-SNAPSHOT</powerauth.version>
<powerauth-crypto.version>1.9.0</powerauth-crypto.version>
<powerauth-push.version>1.9.0-SNAPSHOT</powerauth-push.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -345,7 +345,7 @@
<dependency>
<groupId>de.skuzzle.enforcer</groupId>
<artifactId>restrict-imports-enforcer-rule</artifactId>
<version>2.5.0</version>
<version>2.6.0</version>
</dependency>
</dependencies>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-data-adapter-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-data-adapter-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-mtoken-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-nextstep-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<artifactId>powerauth-nextstep-client</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-nextstep-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<parent>
<groupId>io.getlime.security</groupId>
<artifactId>powerauth-webflow-parent</artifactId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
*/
package io.getlime.security.powerauth.lib.nextstep.model.entity.enumeration;

import lombok.Getter;

/**
* Enumeration representing hashing algorithms.
*
* @author Roman Strobl, [email protected]
*/
@Getter
public enum HashAlgorithm {

/**
Expand All @@ -37,35 +40,30 @@ public enum HashAlgorithm {
/**
* Algorithm argon2id.
*/
ARGON_2ID("argon2id", 2);
ARGON_2ID("argon2id", 2),

BCRYPT("bcrypt");

private final String name;
private final int id;
private final Integer id;

/**
* Hash algorithm constructor.
* @param name Algorithm name for Modular Crypt Format.
* @param id Algorithm ID in Bouncy Castle library.
* @param name Algorithm name.
*/
HashAlgorithm(String name, int id) {
HashAlgorithm(String name) {
this.name = name;
this.id = id;
this.id = null;
}

/**
* Get algorithm name for Modular Crypt Format.
* @return Algorithm name.
*/
public String getName() {
return name;
}

/**
* Get algorithm ID in Bouncy Castle library.
* @return Algorithm ID.
* Hash algorithm constructor for Argon family of algorithms.
* @param name Algorithm name for Modular Crypt Format.
* @param id Algorithm ID in Bouncy Castle library (Argon algorithms only).
*/
public int getId() {
return id;
HashAlgorithm(String name, int id) {
this.name = name;
this.id = id;
}

}
2 changes: 1 addition & 1 deletion powerauth-nextstep/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<parent>
<groupId>io.getlime.security</groupId>
<artifactId>powerauth-webflow-parent</artifactId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.security.crypto.bcrypt.BCrypt;
import org.springframework.stereotype.Service;

import java.io.IOException;
Expand Down Expand Up @@ -100,6 +101,10 @@ public CredentialValue protectCredential(String credentialValue, CredentialEntit
final String hashedValue = argon2Hash.toString();
return credentialValueConverter.toDBValue(hashedValue, userId, credentialDefinition);
}
case BCRYPT -> {
String hashedValue = BCrypt.hashpw(credentialValue, BCrypt.gensalt());
return credentialValueConverter.toDBValue(hashedValue, userId, credentialDefinition);
}
default -> throw new InvalidConfigurationException("Unsupported hashing algorithm: " + algorithm);
}
}
Expand Down Expand Up @@ -132,6 +137,13 @@ public boolean verifyCredential(String credentialValue, CredentialEntity credent
}
return succeeded;
}
case BCRYPT -> {
boolean succeeded = BCrypt.checkpw(credentialValue, decryptedCredentialValue);
if (succeeded) {
updateStoredCredentialValueIfRequired(credentialValue, credential);
}
return succeeded;
}
default -> throw new InvalidConfigurationException("Unsupported hashing algorithm: " + algorithm);
}
}
Expand All @@ -154,6 +166,7 @@ public boolean verifyCredentialHistory(String credentialValue, CredentialHistory
final HashAlgorithm algorithm = hashingConfig.getAlgorithm();
return switch (algorithm) {
case ARGON_2I, ARGON_2D, ARGON_2ID -> verifyCredentialUsingArgon2(credentialValue, algorithm, decryptedCredentialValue);
case BCRYPT -> BCrypt.checkpw(credentialValue, decryptedCredentialValue);
};
}

Expand Down Expand Up @@ -335,7 +348,7 @@ private void updateStoredCredentialValueIfRequired(String credentialValue, Crede
updateRequired = true;
} else {
// Check actual argon2 parameters from the hash in the database and compare them with credential definition
updateRequired = updateRequired || !argon2ParamMatch(extractCredentialValue(credential), credentialDefinition.getHashingConfig().getAlgorithm(), credential.getHashingConfig().getParameters());
updateRequired = updateRequired || (credentialDefinition.getHashingConfig().getAlgorithm() != HashAlgorithm.BCRYPT && !argon2ParamMatch(extractCredentialValue(credential), credentialDefinition.getHashingConfig().getAlgorithm(), credential.getHashingConfig().getParameters()));
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
/*
* PowerAuth Web Flow and related software components
* Copyright (C) 2024 Wultra s.r.o.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published
* by the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package io.getlime.security.powerauth.app.nextstep.service;

import com.fasterxml.jackson.databind.ObjectMapper;
import io.getlime.security.powerauth.app.nextstep.NextStepTest;
import io.getlime.security.powerauth.app.nextstep.repository.model.entity.CredentialDefinitionEntity;
import io.getlime.security.powerauth.app.nextstep.repository.model.entity.CredentialEntity;
import io.getlime.security.powerauth.app.nextstep.repository.model.entity.HashConfigEntity;
import io.getlime.security.powerauth.app.nextstep.repository.model.entity.UserIdentityEntity;
import io.getlime.security.powerauth.lib.nextstep.model.entity.CredentialValue;
import io.getlime.security.powerauth.lib.nextstep.model.entity.enumeration.EncryptionAlgorithm;
import io.getlime.security.powerauth.lib.nextstep.model.entity.enumeration.HashAlgorithm;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;

import java.util.Map;

import static org.junit.jupiter.api.Assertions.*;

/**
* Tests for password hashing.
*
* @author Roman Strobl, [email protected]
*/
class CredentialProtectionServiceTest extends NextStepTest {

@Autowired
private CredentialProtectionService credentialProtectionService;

@Test
void testBcrypt() throws Exception {
final CredentialEntity credentialEntity = new CredentialEntity();
final UserIdentityEntity user = new UserIdentityEntity();
final HashConfigEntity hashConfig = new HashConfigEntity();
final CredentialDefinitionEntity credentialDefinition = new CredentialDefinitionEntity();
credentialDefinition.setEncryptionAlgorithm(EncryptionAlgorithm.NO_ENCRYPTION);
credentialDefinition.setHashingConfig(hashConfig);
hashConfig.setAlgorithm(HashAlgorithm.BCRYPT);
hashConfig.setParameters("{}");
user.setUserId("test");
credentialEntity.setUser(user);
credentialEntity.setCredentialDefinition(credentialDefinition);
credentialEntity.setHashingConfig(hashConfig);
final CredentialValue hashed = credentialProtectionService.protectCredential("test", credentialEntity);
credentialEntity.setValue(hashed.getValue());
assertEquals(EncryptionAlgorithm.NO_ENCRYPTION, hashed.getEncryptionAlgorithm());
assertNotEquals("test", hashed.getValue());
assertTrue(hashed.getValue().startsWith("$2a$10$"));
assertTrue(credentialProtectionService.verifyCredential("test", credentialEntity));
}

@Test
void testArgon2() throws Exception {
final CredentialEntity credentialEntity = new CredentialEntity();
final UserIdentityEntity user = new UserIdentityEntity();
final HashConfigEntity hashConfig = new HashConfigEntity();
final CredentialDefinitionEntity credentialDefinition = new CredentialDefinitionEntity();
credentialDefinition.setEncryptionAlgorithm(EncryptionAlgorithm.NO_ENCRYPTION);
credentialDefinition.setHashingConfig(hashConfig);
hashConfig.setAlgorithm(HashAlgorithm.ARGON_2I);
final Map<String, String> params = Map.of(
"version", "19",
"iterations", "4",
"memory", "16",
"parallelism", "2",
"outputLength", "32"
);
hashConfig.setParameters(new ObjectMapper().writeValueAsString(params));
user.setUserId("test");
credentialEntity.setUser(user);
credentialEntity.setCredentialDefinition(credentialDefinition);
credentialEntity.setHashingConfig(hashConfig);
final CredentialValue hashed = credentialProtectionService.protectCredential("test", credentialEntity);
credentialEntity.setValue(hashed.getValue());
assertEquals(EncryptionAlgorithm.NO_ENCRYPTION, hashed.getEncryptionAlgorithm());
assertNotEquals("test", hashed.getValue());
assertTrue(hashed.getValue().startsWith("$argon2i$v=19$m=65536,t=4,p=2$"));
assertTrue(credentialProtectionService.verifyCredential("test", credentialEntity));
}

}
2 changes: 1 addition & 1 deletion powerauth-tpp-engine-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<name>powerauth-tpp-engine-client</name>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-tpp-engine-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<name>powerauth-tpp-engine-model</name>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-tpp-engine/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<parent>
<groupId>io.getlime.security</groupId>
<artifactId>powerauth-webflow-parent</artifactId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-webflow-authentication-approval-sca/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<name>powerauth-webflow-authentication-approval-sca</name>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-webflow-authentication-consent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<artifactId>powerauth-webflow-authentication-consent</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-webflow-authentication-form/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<name>powerauth-webflow-authentication-form</name>
Expand Down
2 changes: 1 addition & 1 deletion powerauth-webflow-authentication-init/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<parent>
<artifactId>powerauth-webflow-parent</artifactId>
<groupId>io.getlime.security</groupId>
<version>1.8.0</version>
<version>1.9.0-SNAPSHOT</version>
</parent>

<name>powerauth-webflow-authentication-init</name>
Expand Down
Loading
Loading